Skip to content

Fix remaining bugs in the redesigned widgets #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

naschmitz
Copy link
Collaborator

Fixes 3 bugs:

  • Sometimes keyboard events would propagate up to the document and it could trigger keyboard shortcuts in Jupyter Lab.
  • The min and max values are set to NaN when changing the inputs via the keyboard.
  • Clicking on the "All layers on/off" text in the layer manager wouldn't trigger the checkbox.

…elds on RasterLayerEditor.

The first issue was sometimes keyboard events would propagate up to the document and it could trigger keyboard shortcuts in Jupyter Lab.

The second issue was min and max values being set to NaN when changing the inputs via the keyboard.
@naschmitz naschmitz requested review from schwehr, giswqs and jdbcode June 20, 2025 18:27
@naschmitz naschmitz merged commit 15db2ff into gee-community:master Jun 23, 2025
14 of 15 checks passed
@naschmitz naschmitz deleted the phase-2-bug-fixes branch June 23, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants