feat(grok): support ACP model switching#2903
Open
janburzinski wants to merge 6 commits into
Open
Conversation
…tching # Conflicts: # packages/ui/src/react/components/chat-composer/index.tsx
Collaborator
Author
Contributor
Greptile SummaryThis PR adds model switching for Grok ACP sessions. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/src/renderer/features/conversations/acp/acp-chat-panel.tsx | Synchronizes attachment state during asynchronous prompt preparation and displays model-switch progress. |
| apps/emdash-desktop/src/renderer/features/conversations/acp/acp-chat-store.ts | Serializes model changes, blocks prompts during transitions, and clears optimistic state after completion or failure. |
| packages/plugins/src/agents/impl/grok/acp.ts | Adds the Grok-specific ACP adapter for model normalization and session/set_model requests. |
| packages/ui/src/react/components/chat-composer/index.tsx | Disables model and send controls while a model change is pending and renders a progress indicator. |
Reviews (3): Last reviewed commit: "fix(chat): resolve ACP submission races" | Re-trigger Greptile
janburzinski
marked this pull request as ready for review
July 17, 2026 16:06
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Add model switching for Grok ACP sessions by normalizing Grok's model state into ACP config options and translating model changes to
session/set_model.The chat composer now keeps model changes serialized, blocks prompts while a switch is pending, shows progress, and rolls back cleanly when the change fails.
Switching between Composer 2.5 and Grok 4.5 took roughly eight seconds in local testing because Grok rebuilds its harness and re-registers skills and MCP servers during
session/set_model. The pending state makes that provider-side work visible and prevents prompts from racing the harness rebuild.Screen recording
https://cap.link/q82zyr2dpw269fj
Checklist