Changes to cargo to allow to depend only on the base client#3
Open
huevosabio wants to merge 5 commits into
Open
Changes to cargo to allow to depend only on the base client#3huevosabio wants to merge 5 commits into
huevosabio wants to merge 5 commits into
Conversation
Collaborator
|
wild idea - what do you think about splitting out the base client into its own crate? That might make this a bit smoother than the feature gating technique. |
Collaborator
|
I may be able to spend some time on that approach - but wanted to check if that would work for you. Out of curiosity, what are you using the base client for? |
Author
|
I don't oppose to having the base client being its own crate! That may make everything easier. But it's up to you, is your product after all :) I am building a godot client for convex, using the rust base client: https://github.com/clementine-tech/convex-gd This is so I can power games with AI workflows :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some small changes in the feature flags so that it is possible to compile or depend only on the base client.
I am building a [Godot client] and want to keep the ability to compile cross-platform, including web. The full client version of
convex-rsdepends on libraries that cannot be compiled to wasm.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.