fix(init): skip artifact dirs in project listing#1081
Merged
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4834 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.53% 81.53% —%
==========================================
Files 374 374 —
Lines 26173 26174 +1
Branches 17080 17080 —
==========================================
+ Hits 21339 21340 +1
- Misses 4834 4834 —
- Partials 1768 1768 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps generated output directories from spending the init
list-direntry budget. The directories still appear in the listing, but init no longer recurses into artifact-heavy folders.This also moves high-confidence generated/cache folders into the shared scanner
DEFAULT_SKIP_DIRSlist, including package-manager caches, Python tool caches, framework outputs, native/.NET build output, and coverage outputs. Init keeps only the more debatable budget-only extras (bin,tmp,temp,Pods) on top of that shared policy.This is intentionally narrower than #1080: no traversal rewrite, no response-shape changes, no depth change, and no platform-specific filename additions.
Test Plan
pnpm exec vitest run test/lib/init/tools/list-dir.test.ts test/lib/init/tools/filesystem-tools.test.ts test/lib/scan/constants.property.test.ts test/lib/scan/walker.test.tspnpm exec biome check src/lib/scan/constants.ts src/lib/init/tools/list-dir.ts test/lib/init/tools/list-dir.test.ts test/lib/scan/constants.property.test.ts