chore: fix analyze in Dart and Hive #3174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3174 +/- ##
=======================================
Coverage 87.78% 87.78%
=======================================
Files 291 291
Lines 9896 9896
=======================================
Hits 8687 8687
Misses 1209 1209 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| 6f47800 | 451.04 ms | 509.64 ms | 58.60 ms |
| 79f6b41 | 469.66 ms | 525.90 ms | 56.24 ms |
| 0fb3800 | 465.64 ms | 536.77 ms | 71.13 ms |
| cc4e375 | 426.15 ms | 482.34 ms | 56.19 ms |
| f761369 | 462.73 ms | 563.80 ms | 101.06 ms |
| de377fd | 572.35 ms | 589.21 ms | 16.87 ms |
| 6b69699 | 456.06 ms | 557.44 ms | 101.38 ms |
| 0fb45d0 | 482.79 ms | 554.02 ms | 71.23 ms |
| 827bf09 | 475.40 ms | 547.14 ms | 71.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 6f47800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 79f6b41 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb3800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| cc4e375 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| f761369 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| de377fd | 6.54 MiB | 7.71 MiB | 1.17 MiB |
| 6b69699 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 0fb45d0 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 827bf09 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
denrase
requested changes
Aug 18, 2025
| @@ -3,24 +3,24 @@ import 'dart:collection'; | |||
| import 'package:meta/meta.dart'; | |||
|
|
|||
| @internal | |||
| class AccessAwareMap<String, V> extends MapBase<String, V> { | |||
| class AccessAwareMap<K, V> extends MapBase<K, V> { | |||
There was a problem hiding this comment.
Wh is this needed? The key is supposed to be string indexed.
There was a problem hiding this comment.
class AccessAwareMap extends MapBase<String, V> {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes analyze errors in Dart and Hive
#skip-changelog