test-opt: fix backend support check #15317
Merged
+40
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Aug 15, 2025
Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in
tests/test-optwere never activated in the llama.cpp repository until #13873 . The problem is thatggml_optinternally tries to allocate AdamW/SGD optimizer steps which are not supported in all backends. So it becomes necessary to check support for these optimizer steps ahead of time (otherwise the intentionally simple functionggml_opt_fitwould need to be made overly complicated). This PR allocates simple test tensors for the ops in the test code, if the ops are not supported the tests are skipped.