Skip to content

common : restore --n-gpu-layers#9371

Merged
ngxson merged 1 commit into
masterfrom
sl/fix-ngl-arg
Sep 8, 2024
Merged

common : restore --n-gpu-layers#9371
ngxson merged 1 commit into
masterfrom
sl/fix-ngl-arg

Conversation

@slaren

@slaren slaren commented Sep 8, 2024

Copy link
Copy Markdown
Member

This commonly used variation of the command line argument was removed in #9308.

@slaren
slaren requested a review from ngxson September 8, 2024 13:08

@ngxson ngxson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

FYI part of my code in #9308 was auto-migrated using a script. Since it takes gpt_params_print_usage as reference, some arguments maybe missed. I'll do another pass to make sure no args is dropped.

@ngxson
ngxson merged commit a249843 into master Sep 8, 2024
@slaren
slaren deleted the sl/fix-ngl-arg branch September 8, 2024 14:45
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants