Remove unused DomainProtocol export from domain-patterns.ts

[Copilot]

DomainProtocol was exported from src/domain-patterns.ts but had zero external consumers, adding unnecessary public API surface.

Change

• Removed export from DomainProtocol in src/domain-patterns.ts; it remains in scope for the ParsedDomain interface defined in the same file

-export type DomainProtocol = 'http' | 'https' | 'both';
+type DomainProtocol = 'http' | 'https' | 'both';

[Copilot]

Pull request overview

This PR reduces public API surface area by making DomainProtocol an internal (module-scoped) type in src/domain-patterns.ts, while keeping it available for the exported interfaces in that same module.

Changes:

• Removed the export modifier from the DomainProtocol type alias.
• Kept DomainProtocol in local scope so exported types like ParsedDomain can continue to use it without change.

Show a summary per file

File	Description
src/domain-patterns.ts	Makes DomainProtocol non-exported while retaining it for internal typing of exported interfaces.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0

[github-actions]

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

[github-actions]

🔌 Smoke Services — All services reachable! ✅

[github-actions]

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

[github-actions]

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

[github-actions]

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

[github-actions]

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

[github-actions]

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

[github-actions]

✅ Smoke Claude passed

[github-actions]

✅ Smoke Gemini completed. All facets verified. 💎

[github-actions]

✅ Build Test Suite completed successfully!

[github-actions]

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

[github-actions]

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.01%	98.05%	📈 +0.04%
Statements	97.95%	97.98%	📈 +0.03%
Functions	99.51%	99.51%	➡️ +0.00%
Branches	93.68%	93.72%	📈 +0.04%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
src/workdir-setup.ts	92.7% → 94.5% (+1.82%)	92.7% → 94.5% (+1.82%)

---

Coverage comparison generated by scripts/ci/compare-coverage.ts

[github-actions]

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

[github-actions]

Smoke Test Results: Copilot BYOK (Direct Mode) ✅

Tests:

• ✅ GitHub MCP: Connected (verified merged PRs query)
• ✅ GitHub.com: HTTP 200
• ✅ BYOK Inference: api-proxy → api.githubcopilot.com path working

Status: PASS — Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar

@lpcox @Copilot

🔑 BYOK report filed by Smoke Copilot BYOK

[github-actions]

Smoke Test: Claude Engine Validation

Check	Result
API Status	✅ PASS
GH Check	✅ PASS
File Status	✅ PASS

Overall Result: PASS

Generated by Smoke Claude for issue #5395 · 36.9 AIC · ⊞ 3.1K · ◷

[github-actions]

🔥 Smoke Test: Copilot PAT Auth — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP (200)	✅
File write/read	✅

Overall: PASS · Auth mode: PAT (COPILOT_GITHUB_TOKEN)

CC @lpcox @Copilot

🔑 PAT report filed by Smoke Copilot PAT

[github-actions]

🔥 Smoke Test Results

PR: Remove unused DomainProtocol export from domain-patterns.ts
Author: @Copilot | Assignees: @lpcox, @Copilot

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP (200)	✅
File write/read	❌ (template vars unresolved)

Overall: FAIL — pre-step template substitution did not execute (${{ steps.smoke-data.outputs.* }} unexpanded).

📰 BREAKING: Report filed by Smoke Copilot

[github-actions]

Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Details
✅ Module Loading	Pass	otel.js loads successfully; exports startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled + test helpers; isEnabled() returns true
✅ Test Suite	Pass	59/59 tests passed across otel.test.js + otel-fanout.test.js
✅ Env Var Forwarding	Pass	src/services/api-proxy-service-config.ts forwards GH_AW_OTLP_ENDPOINTS, OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS, GITHUB_AW_OTEL_TRACE_ID, GITHUB_AW_OTEL_PARENT_SPAN_ID, OTEL_SERVICE_NAME
✅ Token Tracker Integration	Pass	onUsage callback exists in token-tracker-http.js (line 324) as the OTEL hook point
✅ OTEL Diagnostics	Pass	Graceful degradation confirmed — no endpoint configured → FileSpanExporter fallback to /var/log/api-proxy/otel.jsonl; no errors

All scenarios passed ✅

📡 OTel tracing validated by Smoke OTel Tracing

[github-actions]

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ No
Node.js	v24.16.0	v22.22.3	❌ No
Go	go1.22.12	go1.22.12	✅ Yes

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

[github-actions]

fix: propagate config fields to all layers ✅
[Test Coverage] squid-log-reader.ts: 100% coverage ✅
Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

[github-actions]

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note (Java): Maven's local repository (~/.m2) was owned by root in this environment. Tests passed after using -Dmaven.repo.local=/tmp/gh-aw/agent/.m2/repository as a workaround.

Generated by Build Test Suite for issue #5395 · 33.7 AIC · ⊞ 7.7K · ◷

[github-actions]

• GitHub MCP Testing: ❌ (No tools available)
• GitHub.com Connectivity: ❌ (Failed: SSL error 35)
• File Writing Testing: ✅
• Bash Tool Testing: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

[github-actions]

Smoke Test Results — Services Connectivity

Check	Result
Redis PING	❌ No response
PostgreSQL pg_isready	❌ No response (host.docker.internal:5432 - no response)
PostgreSQL SELECT 1	❌ No response

Overall: FAIL — host.docker.internal is not reachable from this runner environment. Service containers are unavailable.

🔌 Service connectivity validated by Smoke Services

[github-actions]

GitHub MCP Testing: ✅
GitHub.com connectivity: ✅
File write/read test: ✅
BYOK inference: ✅
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
Overall: PASS
@Copilot @lpcox

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)