refactor: extract shared helper to eliminate duplicate test scaffold in docker-host-env tests by Copilot · Pull Request #5419 · github/gh-aw-firewall

Copilot · 2026-06-22T22:53:10Z

Three tests in src/docker-host-env.test.ts repeated an identical ~20-line block: temp dir setup, two mockResolvedValueOnce calls, startContainers invocation, compose-call filtering, env extraction, and cleanup.

Changes

src/docker-host-env.test.ts: extracted runStartContainersAndGetComposeEnv() as an inline helper inside the describe block. It owns the full scaffold and returns the env object from the first docker compose call. Each test now only sets up its DOCKER_HOST/setAwfDockerHost precondition and asserts the expected forwarded value.

Before (repeated three times):

const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'awf-test-'));
try {
  mockExecaFn.mockResolvedValueOnce({ stdout: '', stderr: '', exitCode: 0 } as any);
  mockExecaFn.mockResolvedValueOnce({ stdout: '', stderr: '', exitCode: 0 } as any);
  await startContainers(testDir, ['github.com']);
  const composeCalls = mockExecaFn.mock.calls.filter((call: any[]) => call[1]?.[0] === 'compose');
  expect(composeCalls.length).toBeGreaterThan(0);
  const composeEnv = composeCalls[0][2]?.env as Record<string, string | undefined> | undefined;
  expect(composeEnv!.DOCKER_HOST).toBe('...');
} finally {
  fs.rmSync(testDir, { recursive: true, force: true });
}

After:

process.env.DOCKER_HOST = 'tcp://localhost:2375';
const composeEnv = await runStartContainersAndGetComposeEnv();
expect(composeEnv).toBeDefined();
expect(composeEnv!.DOCKER_HOST).toBe('tcp://localhost:2375');

Net result: ~30 lines removed, assertion consistency guaranteed across all three ARC/DinD DOCKER_HOST boundary tests.

Copilot

Pull request overview

This PR refactors src/docker-host-env.test.ts to remove duplicated test scaffolding around startContainers calls, improving consistency and reducing repetition in the DOCKER_HOST isolation tests.

Changes:

Extracted a shared inline helper runStartContainersAndGetComposeEnv() within the describe block to centralize temp dir setup, mocked execa results, startContainers() execution, and docker compose env extraction.
Updated the three DOCKER_HOST boundary tests to use the helper and focus only on preconditions + assertions.

Show a summary per file

File	Description
src/docker-host-env.test.ts	Refactors repeated test setup into a shared helper and simplifies the three DOCKER_HOST forwarding/override tests.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 0

github-actions · 2026-06-23T14:51:00Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-06-23T14:51:01Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-06-23T14:51:01Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-06-23T14:51:02Z

✅ Smoke Claude passed

github-actions · 2026-06-23T14:51:03Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-06-23T14:51:04Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-06-23T14:51:11Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-06-23T14:51:17Z

✅ Build Test Suite completed successfully!

github-actions · 2026-06-23T14:51:18Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-06-23T14:51:19Z

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

github-actions · 2026-06-23T14:51:29Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-06-23T14:51:44Z

✅ Smoke Gemini completed. All facets verified. 💎

github-actions · 2026-06-23T14:51:55Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.01%	98.05%	📈 +0.04%
Statements	97.95%	97.98%	📈 +0.03%
Functions	99.51%	99.51%	➡️ +0.00%
Branches	93.68%	93.72%	📈 +0.04%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/workdir-setup.ts`	92.7% → 94.5% (+1.82%)	92.7% → 94.5% (+1.82%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-06-23T14:54:18Z

Smoke Test: Copilot BYOK (Direct Mode) ✅ PASS

Test Results:

✅ GitHub MCP Testing: Connectivity confirmed
✅ GitHub.com Connectivity: HTTP 200
✅ File Write/Read Test: Verified
✅ BYOK Inference: Agent responding (api-proxy → api.githubcopilot.com)

Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-06-23T14:54:19Z

Smoke Test: Claude Engine Validation

Check	Status
API	✅ PASS
gh CLI	✅ PASS
File operations	✅ PASS

Overall result: PASS

Generated by Smoke Claude for issue #5419 · 36.8 AIC · ⊞ 3.1K · ◷

github-actions · 2026-06-23T14:54:43Z

🔥 Smoke Test Results — PASS

Test	Status
GitHub MCP connectivity	✅
GitHub.com HTTP (200)	✅
File write/read	✅

PR: refactor: extract shared helper to eliminate duplicate test scaffold in docker-host-env tests
Author: @Copilot | Assignees: @lpcox @Copilot

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-23T14:54:50Z

🔥 Smoke Test Results — Auth mode: PAT (COPILOT_GITHUB_TOKEN)

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP (200)	✅
File write/read	❌ (pre-step outputs not resolved)

Overall: FAIL

cc @lpcox — PR by @Copilot, assigned to @lpcox @Copilot

🔑 PAT report filed by Smoke Copilot PAT

github-actions · 2026-06-23T14:55:45Z

@lpcox

GitHub MCP Testing: ✅
GitHub.com Connectivity: ✅
File Write/Read Test: ✅
BYOK Inference Test: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-06-23T14:56:20Z

Gemini Smoke Test Results

PR: Remove unused ParsedDomainList export from domain-matchers (Remove unused ParsedDomainList export from domain-matchers #5398)
PR: (Unknown - history limited)
GitHub MCP Testing: ❌
GitHub.com Connectivity: ❌
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

github-actions · 2026-06-23T14:56:30Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌
Node.js	v24.16.0	v22.22.3	❌
Go	go1.22.12	go1.22.12	✅

Overall: ❌ Tests did not pass — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

github-actions · 2026-06-23T14:56:54Z

📡 OTel Tracing Smoke Test Results

Scenario	Result
S1: Module Loading	✅ `otel.js` loaded, `isEnabled: true`, exports: `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`
S2: Test Suite	✅ 59 tests passed, 0 failed (2 suites: `otel.test.js`, `otel-fanout.test.js`)
S3: Env Var Forwarding	✅ `api-proxy-service-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID` via `pickEnvVars`
S4: Token Tracker Integration	✅ `token-tracker-http.js` has `onUsage` callback (OTEL hook point)
S5: OTEL Diagnostics	i️ No span file (expected — no live api-proxy container in this run)

All scenarios pass. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-06-23T14:57:01Z

Smoke Test

Remove unused ParsedDomainList export from domain-matchers ✅
Remove unused ParsedDomain from domain-patterns ✅
GitHub title check ✅
File write/read ✅
Discussion lookup/comment ✅
npm ci && npm run build ✅
Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-06-23T14:57:17Z

Smoke Test: GitHub Actions Services Connectivity

Check	Result
Redis PING (`host.docker.internal:6379`)	❌ Connection timed out
PostgreSQL pg_isready (`host.docker.internal:5432`)	❌ No response
PostgreSQL `SELECT 1`	❌ No response

host.docker.internal resolves to 172.17.0.1 but both services are unreachable from this environment.

Overall: FAIL

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-06-23T14:57:31Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5419 · 44.7 AIC · ⊞ 7.7K · ◷

Initial plan

3208884

Copilot AI assigned Copilot and lpcox Jun 22, 2026

Copilot started work on behalf of lpcox June 22, 2026 22:53 View session

refactor: extract helper for docker-host-env duplicate test scaffold

75069d7

Copilot AI changed the title ~~[WIP] Refactor Docker host env tests to remove duplicate code~~ refactor: extract shared helper to eliminate duplicate test scaffold in docker-host-env tests Jun 22, 2026

Copilot AI requested a review from lpcox June 22, 2026 22:57

Copilot finished work on behalf of lpcox June 22, 2026 22:57

lpcox marked this pull request as ready for review June 23, 2026 13:51

Copilot AI review requested due to automatic review settings June 23, 2026 13:51

Copilot started reviewing on behalf of lpcox June 23, 2026 13:52 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

lpcox added the ready-for-aw label Jun 23, 2026

lpcox temporarily deployed to aoai-model June 23, 2026 14:51 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok label Jun 23, 2026

github-actions Bot added smoke-claude smoke-copilot labels Jun 23, 2026

lpcox temporarily deployed to aoai-model June 23, 2026 14:55 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jun 23, 2026

lpcox temporarily deployed to aoai-model June 23, 2026 14:55 — with GitHub Actions Inactive

github-actions Bot added the smoke-codex label Jun 23, 2026

github-actions Bot added the build-test label Jun 23, 2026

lpcox merged commit d9b050a into main Jun 23, 2026
87 of 90 checks passed

lpcox deleted the copilot/fix-duplicate-code-docker-host-tests branch June 23, 2026 15:32

Uh oh!

Conversation

Copilot AI commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 23, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jun 23, 2026

Smoke Test: Copilot BYOK (Direct Mode) ✅ PASS

Uh oh!

github-actions Bot commented Jun 23, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jun 23, 2026

🔥 Smoke Test Results — PASS

Uh oh!

github-actions Bot commented Jun 23, 2026

🔥 Smoke Test Results — Auth mode: PAT (COPILOT_GITHUB_TOKEN)

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026

Gemini Smoke Test Results

Uh oh!

github-actions Bot commented Jun 23, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Jun 23, 2026

📡 OTel Tracing Smoke Test Results

Uh oh!

github-actions Bot commented Jun 23, 2026

Smoke Test

Uh oh!

github-actions Bot commented Jun 23, 2026

Smoke Test: GitHub Actions Services Connectivity

Uh oh!

Copilot AI commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading

github-actions Bot commented Jun 23, 2026 •

edited

Loading