Skip to content

test: fix failing npm test after gh-aw v0.81.0 recompile#5450

Merged
lpcox merged 1 commit into
mainfrom
fix/npm-test-version-pins
Jun 23, 2026
Merged

test: fix failing npm test after gh-aw v0.81.0 recompile#5450
lpcox merged 1 commit into
mainfrom
fix/npm-test-version-pins

Conversation

@lpcox

@lpcox lpcox commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes the failing npm test caused by stale version assertions in the CI workflow tests. The v0.81.0 recompile (#5447) bumped pinned versions, but three workflow tests still asserted the old values.

Failing tests fixed

  • scripts/ci/security-guard-workflow.test.ts
  • scripts/ci/export-audit-workflow.test.ts
  • scripts/ci/test-coverage-improver-workflow.test.ts

Changes

Updated the stale assertions to match the recompiled lock files:

  • github/gh-aw-actions/setup: @c20f9e75… # v0.80.6@3c7f3b6f423dd721e2f115b7c8fda65287e1f137 # v0.81.0
  • ghcr.io/github/github-mcp-server: v1.3.0v1.4.0
  • COPILOT_DUMMY_BYOK: now the offline placeholder dummy-byok-key-for-offline-mode (gh-aw v0.81.0 changed this; it is distinct from AWF's own COPILOT_PLACEHOLDER_TOKEN). The assertions were flipped, keeping a meaningful negative check that the old ghu_ placeholder is gone.

Verification

  • The three suites pass; full npm test is green apart from src/services/agent-volumes-mounts.test.ts, a pre-existing flaky test (passes in isolation; fails only under full-suite parallelism due to env leakage) — unrelated to this change.
  • tsc build passes.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

The v0.81.0 recompile (#5447) bumped the setup action to v0.81.0
(SHA 3c7f3b6f), github-mcp-server to v1.4.0, and changed the offline
COPILOT_DUMMY_BYOK placeholder to 'dummy-byok-key-for-offline-mode'.
Update the stale assertions in the security-guard, export-audit, and
test-coverage-improver workflow tests to match.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 23, 2026 22:13
@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 98.04% 98.08% 📈 +0.04%
Statements 97.97% 98.01% 📈 +0.04%
Functions 99.51% 99.51% ➡️ +0.00%
Branches 93.74% 93.77% 📈 +0.03%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/workdir-setup.ts 92.7% → 94.5% (+1.82%) 92.7% → 94.5% (+1.82%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI workflow unit tests to align with the gh-aw v0.81.0 recompiled workflow lock files, fixing failures caused by stale version/token assertions.

Changes:

  • Update pinned github/gh-aw-actions/setup assertion to the v0.81.0 commit SHA in relevant workflow tests.
  • Update ghcr.io/github/github-mcp-server image assertion from v1.3.0 to v1.4.0.
  • Update COPILOT_DUMMY_BYOK assertion in the security-guard workflow test to expect the new offline placeholder value.
Show a summary per file
File Description
scripts/ci/test-coverage-improver-workflow.test.ts Updates lock-file assertions for setup action pin and github-mcp-server image version.
scripts/ci/security-guard-workflow.test.ts Updates lock-file assertions for COPILOT_DUMMY_BYOK placeholder and pinned dependency versions.
scripts/ci/export-audit-workflow.test.ts Updates lock-file assertion for github-mcp-server image version.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Smoke Claude passed

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Contribution Check completed successfully!

Contribution guidelines review complete: PR #5450 follows the applicable CONTRIBUTING.md requirements; no comment needed.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Security Guard has started processing this pull request

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Build Test Suite completed successfully!

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

🔌 Smoke Services — All services reachable! ✅

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Smoke Gemini completed. All facets verified. 💎

@github-actions

Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Status
GitHub MCP connectivity
github.com HTTP ✅ (200)
File write/read ❌ (pre-step template vars unresolved)

Overall: FAIL

PR: test: fix failing npm test after gh-aw v0.81.0 recompile — author @lpcox

📰 BREAKING: Report filed by Smoke Copilot

@github-actions

Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot PAT — PASS

Test Result
GitHub MCP connectivity
GitHub.com HTTP (200)
File write/read

Overall: PASS · Auth mode: PAT (COPILOT_GITHUB_TOKEN)

/cc @lpcox

🔑 PAT report filed by Smoke Copilot PAT

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ NO
Node.js v24.16.0 v22.22.3 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot environment.

Tested by Smoke Chroot

@github-actions

Copy link
Copy Markdown
Contributor

🔬 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario Result Details
Module Loading otel.js loads cleanly; exports 14 symbols: startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled, plus internal test helpers
Test Suite 59 tests passed, 0 failed across otel.test.js + otel-fanout.test.js
Env Var Forwarding src/services/api-proxy-service-config.ts forwards GH_AW_OTLP_ENDPOINTS, OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS, GITHUB_AW_OTEL_TRACE_ID, GITHUB_AW_OTEL_PARENT_SPAN_ID, OTEL_SERVICE_NAME via pickEnvVars()
Token Tracker Integration onUsage callback present in token-tracker-http.js (line 283); otel.js setTokenAttributes() is documented as called from this hook
OTEL Diagnostics ⏭️ No live api-proxy process during smoke test; when no endpoint is configured spans fall back to /var/log/api-proxy/otel.jsonl (expected behaviour)

All scenarios pass. OTEL tracing integration is healthy on this branch.

📡 OTel tracing validated by Smoke OTel Tracing

@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5450 · 64.2 AIC · ⊞ 7.7K ·

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test Results — Services Connectivity

Check Result
Redis PING (host.docker.internal:6379) ❌ Timeout (RC=124)
PostgreSQL pg_isready (host.docker.internal:5432) ❌ No response
PostgreSQL SELECT 1 ❌ No response

host.docker.internal resolves to 172.17.0.1, but all service connections failed (timeout/no response).

Overall: ❌ FAIL

🔌 Service connectivity validated by Smoke Services

@github-actions

Copy link
Copy Markdown
Contributor

@lpcox

  • GitHub MCP PR data ✅
  • GitHub.com connectivity ✅
  • File write/read ✅
  • Direct BYOK inference ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

@github-actions

Copy link
Copy Markdown
Contributor

@lpcox

Smoke Test Results:

  • test: fix failing npm test after gh-aw v0.81.0 recompile: ✅
  • GitHub MCP connectivity: ✅
  • github.com HTTP: ✅
  • File I/O: ✅
  • Direct BYOK mode (Azure OpenAI, Foundry): ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: Claude Engine

  • API check: ✅ PASS
  • gh CLI check: ✅ PASS
  • File check: ✅ PASS

Overall result: PASS

Generated by Smoke Claude for issue #5450 · 37 AIC · ⊞ 3.1K ·

@github-actions

Copy link
Copy Markdown
Contributor

chore: upgrade gh-aw to v0.81.0 and recompile workflows
refactor: extract buildAgentSecurityConfig from buildAgentService
Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions

Copy link
Copy Markdown
Contributor

✅ Smoke Test: Copilot BYOK (Direct Mode) — PASS

Tests:

  • ✅ MCP connectivity (PR fetch verified)
  • ✅ github.com HTTP 200
  • ✅ File write/read passing
  • ✅ BYOK inference active (api-proxy → api.githubcopilot.com)

Mode: Direct BYOK via COPILOT_PROVIDER_API_KEY

All systems nominal.

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions

Copy link
Copy Markdown
Contributor

Gemini Engine Smoke Test Results

  1. GitHub MCP Testing: ❌ (Tools not found in environment)
  2. GitHub.com Connectivity: ❌ (SSL error 35 / Squid intercept)
  3. File Writing Testing: ✅ (Success)
  4. Bash Tool Testing: ✅ (Success)

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@lpcox lpcox merged commit c7fabe6 into main Jun 23, 2026
89 checks passed
@lpcox lpcox deleted the fix/npm-test-version-pins branch June 23, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants