refactor(copilot): extract buildCopilotModelsRequest to deduplicate /models auth headers by Copilot · Pull Request #5518 · github/gh-aw-firewall

Copilot · 2026-06-25T14:41:20Z

getValidationProbe and getModelsFetchConfig in copilot.js each independently constructed the same /models GET request object — identical URL, Authorization, and Copilot-Integration-Id headers — with no shared source of truth. Any drift (token prefix change, new header, auth mode change) would require matching edits in both places.

Changes

Extracted buildCopilotModelsRequest(extra = {}) — a closure-scoped helper inside createCopilotAdapter that builds the standard /models GET request using githubToken and integrationId.
Both call-sites replaced: getValidationProbe calls it with no args; getModelsFetchConfig passes { cacheKey: 'copilot' } as the extra spread.
The BYOK branch in getModelsFetchConfig (uses apiKey, custom modelsPath) is left intentionally separate — it is a distinct auth mode, not a duplicate.

function buildCopilotModelsRequest(extra = {}) {
  return {
    url: `https://${rawTarget}/models`,
    opts: {
      method: 'GET',
      headers: {
        'Authorization': ['Bearer', githubToken].join(' '),
        'Copilot-Integration-Id': integrationId,
      },
    },
    ...extra,
  };
}

// getValidationProbe
return buildCopilotModelsRequest();

// getModelsFetchConfig (standard target)
return buildCopilotModelsRequest({ cacheKey: 'copilot' });

…ate headers

Copilot

Pull request overview

This PR refactors the Copilot API proxy provider to avoid duplicated construction of the Copilot /models request, reducing the risk of header/auth drift between validation and startup model-fetch behavior.

Changes:

Extracted buildCopilotModelsRequest(extra = {}) inside createCopilotAdapter to build the standard /models GET request object.
Updated getValidationProbe and the standard-target branch of getModelsFetchConfig to use the shared helper.
Left the BYOK/custom provider branch intentionally separate.

Show a summary per file

File	Description
containers/api-proxy/providers/copilot.js	Deduplicates `/models` request construction by extracting a helper used by both validation probing and startup model-fetch config.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-06-25T15:00:33Z

❌ Smoke Gemini reports failed. Facets need polishing...

github-actions · 2026-06-25T15:00:35Z

🔌 Smoke Services — Service connectivity failed ⚠️

github-actions · 2026-06-25T15:00:35Z

❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed...

github-actions · 2026-06-25T15:00:37Z

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

github-actions · 2026-06-25T15:00:37Z

🔑 Smoke Copilot PAT reports failed. PAT auth path may have issues...

github-actions · 2026-06-25T15:00:38Z

❌ Contribution Check failed. Please review the logs for details.

github-actions · 2026-06-25T15:00:40Z

Chroot tests failed Smoke Chroot failed - See logs for details.

github-actions · 2026-06-25T15:00:44Z

Build Test Failed Build Test Suite - See logs for details

github-actions · 2026-06-25T15:00:45Z

📡 Smoke OTel Tracing reports failed. OTel tracing regression detected. ⚠️

github-actions · 2026-06-25T15:00:45Z

🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...

github-actions · 2026-06-25T15:00:57Z

❌ Smoke Copilot BYOK reports failed. BYOK mode investigation needed...

github-actions · 2026-06-25T15:01:17Z

❌ Smoke Claude failed

github-actions · 2026-06-25T15:01:25Z

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

github-actions · 2026-06-25T15:02:30Z

❌ Security Guard failed. Please review the logs for details.

github-actions · 2026-06-25T16:40:34Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-06-25T16:40:51Z

❌ Security Guard failed. Please review the logs for details.

github-actions · 2026-06-25T16:40:54Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-06-25T16:41:07Z

✅ Smoke Claude passed

github-actions · 2026-06-25T16:43:46Z

🔥 Smoke Test Results

Test	Status
GitHub MCP connectivity	✅ PASS
GitHub.com HTTP connectivity	⚠️ N/A (template vars not expanded)
File write/read	⚠️ N/A (template vars not expanded)

PR: refactor(copilot): extract buildCopilotModelsRequest to deduplicate /models auth headers
Author: @Copilot | Assignees: @lpcox @Copilot

Overall: PARTIAL PASS — MCP verified ✅; pre-step outputs unavailable (pipeline variable expansion issue).

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-25T16:43:56Z

🔬 Smoke Test: Copilot PAT Auth — PR #5518

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP status	✅ 200
File write/read	⚠️ template vars unexpanded

Overall: PASS (2/2 verifiable tests passed; file test skipped due to unexpanded workflow variables)

PR: refactor(copilot): extract buildCopilotModelsRequest to deduplicate /models auth headers
Author: @Copilot · Assignees: @lpcox @Copilot
Auth mode: PAT (COPILOT_GITHUB_TOKEN)

🔑 PAT report filed by Smoke Copilot PAT

github-actions · 2026-06-25T16:44:16Z

Smoke Test: Claude Engine Validation

Check	Result
API Status	✅ PASS
GH Check	✅ PASS
File Status	✅ PASS

Overall Result: PASS

Generated by Smoke Claude for issue #5518 · 61.8 AIC · ⊞ 3.3K · ◷

github-actions · 2026-06-25T16:44:56Z

Smoke Test: Copilot BYOK
✅ GitHub MCP connectivity
✅ GitHub.com HTTP 200
✅ File write/read verified
✅ BYOK inference (api-proxy → api.githubcopilot.com)

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar.

Status: PASS

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-06-25T16:44:59Z

@lpcox @Copilot
refactor(api-proxy): extract guard enforcement into proxy-guards.js ✅
refactor(copilot): extract buildCopilotModelsRequest to deduplicate /models auth headers ✅
GitHub.com connectivity ✅
File write/read ✅
BYOK inference ✅
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-06-25T16:45:33Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5518 · 42.8 AIC · ⊞ 7.8K · ◷

github-actions · 2026-06-25T16:45:52Z

Merged PRs:

refactor(api-proxy): extract sliding-window data structure into rate-limiter-window.js
refactor: split agent-volumes-mounts.test.ts by feature area

✅ GitHub PR list
✅ GitHub title check
✅ temp file write/read
✅ discussion comment
✅ npm ci && npm run build

Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-06-25T16:46:26Z

Smoke Test Results — FAIL

Check	Result
Redis PING	❌ Timeout (port 6379 unreachable)
PostgreSQL pg_isready	❌ No response (port 5432 unreachable)
PostgreSQL SELECT 1	❌ Not attempted (pg_isready failed)

host.docker.internal resolves to 172.17.0.1 but both service ports timed out. Service containers do not appear to be reachable from this runner environment.

Overall: FAIL

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-06-25T16:46:36Z

🔬 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Notes
1. Module Loading	✅ Pass	`otel.js` loads; exports `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled` + test helpers
2. Test Suite	✅ Pass	59/59 tests passed across 2 suites (`otel.test.js`, `otel-fanout.test.js`)
3. Env Var Forwarding	✅ Pass	`api-proxy-env-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME`
4. Token Tracker Integration	✅ Pass	`onUsage` callback present in `token-tracker-http.js` (line 324) as the OTEL hook point
5. OTEL Diagnostics	✅ Pass	No OTLP endpoint configured → graceful degradation to `FileSpanExporter` writing `/var/log/api-proxy/otel.jsonl`; `isEnabled()` returns `true`

All 5 scenarios pass. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-06-25T16:47:37Z

Smoke test PASS for:

refactor(api-proxy): extract guard enforcement into proxy-guards.js
refactor(copilot): extract buildCopilotModelsRequest to deduplicate /models auth headers
✅ MCP connectivity
✅ github.com connectivity
✅ File I/O
✅ BYOK inference
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
cc @lpcox @Copilot

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-06-25T16:48:16Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ NO
Node.js	v24.17.0	v22.23.0	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

github-actions · 2026-06-25T16:51:32Z

Smoke Test Results: Gemini\n- PR #5523: refactor(api-proxy): extract sliding-window data structure into rate-limiter-window.js ✅\n- PR #5522: refactor: split agent-volumes-mounts.test.ts by feature area ✅\n- GitHub.com Connectivity: 200 ✅\n- File Writing & Bash Tooling: Verified ✅\n\nOverall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

Initial plan

0b5c92b

Copilot AI assigned Copilot and lpcox Jun 25, 2026

Copilot started work on behalf of lpcox June 25, 2026 14:41 View session

refactor(copilot): extract buildCopilotModelsRequest to remove duplic…

ca958ba

…ate headers

Copilot AI changed the title ~~[WIP] Fix duplicate OAuth header construction in model-fetch requests~~ refactor(copilot): extract buildCopilotModelsRequest to deduplicate /models auth headers Jun 25, 2026

Copilot finished work on behalf of lpcox June 25, 2026 14:44

Copilot AI requested a review from lpcox June 25, 2026 14:44

lpcox marked this pull request as ready for review June 25, 2026 14:45

Copilot AI review requested due to automatic review settings June 25, 2026 14:45

Copilot started reviewing on behalf of lpcox June 25, 2026 14:45 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread containers/api-proxy/providers/copilot.js Outdated

Potential fix for pull request finding

6448f33

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

lpcox added the ready-for-aw label Jun 25, 2026

lpcox had a problem deploying to aoai-model June 25, 2026 15:00 — with GitHub Actions Failure

github-advanced-security AI found potential problems Jun 25, 2026

View reviewed changes

Comment thread containers/api-proxy/providers/copilot.js Fixed

lpcox temporarily deployed to aoai-model June 25, 2026 16:40 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-pat label Jun 25, 2026

github-actions Bot added the smoke-claude label Jun 25, 2026

github-actions Bot mentioned this pull request Jun 25, 2026

[aw] No-Op Runs #5368

Open

lpcox temporarily deployed to aoai-model June 25, 2026 16:44 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok label Jun 25, 2026

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jun 25, 2026

lpcox temporarily deployed to aoai-model June 25, 2026 16:45 — with GitHub Actions Inactive

github-actions Bot added the build-test label Jun 25, 2026

github-actions Bot added the smoke-codex label Jun 25, 2026

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jun 25, 2026

github-actions Bot added the smoke-gemini label Jun 25, 2026

lpcox merged commit 9235c70 into main Jun 25, 2026
85 of 88 checks passed

lpcox deleted the copilot/fix-duplicate-oauth-header-construction branch June 25, 2026 17:22

Uh oh!

Conversation

Copilot AI commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026

🔥 Smoke Test Results

Uh oh!

github-actions Bot commented Jun 25, 2026

🔬 Smoke Test: Copilot PAT Auth — PR #5518

Uh oh!

github-actions Bot commented Jun 25, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

Copilot AI commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading

github-actions Bot commented Jun 25, 2026 •

edited

Loading