refactor: split squid-config-features.test.ts into focused files by feature area#5572
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Squid configuration feature tests by splitting the previously large src/squid-config-features.test.ts into smaller, feature-focused Jest test files, improving navigability and isolating failures without changing production behavior.
Changes:
- Deleted the monolithic
src/squid-config-features.test.ts. - Added five focused test files covering logging, streaming timeouts, blocklist behavior, SSL bump behavior, and DLP/empty-domain behavior.
Show a summary per file
| File | Description |
|---|---|
| src/squid-config-features.test.ts | Removes the prior all-in-one feature test file to enable more focused test organization. |
| src/squid-config-logging.test.ts | Adds logging/audit JSONL and access_log-related config assertions. |
| src/squid-config-streaming.test.ts | Adds assertions for long-lived/streaming timeout-related Squid directives. |
| src/squid-config-blocklist.test.ts | Adds blocklist ACL/rule ordering and wildcard behavior coverage. |
| src/squid-config-ssl-bump.test.ts | Adds SSL bump section/rule coverage including URL ACL ordering assertions. |
| src/squid-config-dlp.test.ts | Adds empty-domain and DLP rule ordering/interaction coverage. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
✅ Copilot review passed with no inline comments. @copilot Add the |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅ |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
🚀 Security Guard has started processing this pull request |
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓 |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓 |
|
✅ Build Test Suite completed successfully! |
|
🔌 Smoke Services — All services reachable! ✅ |
|
✅ Smoke Claude passed |
|
❌ Contribution Check failed. Please review the logs for details. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
🔥 Smoke Test: PAT Auth
Overall: PASS — Auth mode: PAT (COPILOT_GITHUB_TOKEN) cc
|
Fixed in the latest commit. The CI failure was caused by a missing closing |
Smoke Test: Claude Engine Validation
Overall result: PASS
|
Smoke Test: Copilot BYOK ✅
Status: PASS
|
🔍 Smoke Test Results — PASS
PR: refactor: split squid-config-features.test.ts into focused files by feature area Overall: PASS
|
|
Reviewed merged PRs:
Checks:
Overall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Version Comparison Results
Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environments.
|
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
📡 Smoke Test: API Proxy OpenTelemetry Tracing
Summary: Core OTEL implementation is solid (module loads, 59 tests pass, token-tracker hook in place). Env var forwarding from the AWF CLI to the api-proxy container is the one remaining gap — expected pending work.
|
|
Smoke test results:
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall: PASS
|
Smoke Test Results — Services Connectivity
Overall: FAIL
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
GitHub MCP: ✅ Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) Overall: PASS
|
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
src/squid-config-features.test.ts(632 lines) mixed five independent security feature test domains into a single file, making it hard to isolate failures and navigate during code review.Changes
src/squid-config-features.test.tssquid-config-logging.test.tssquid-config-streaming.test.tshalf_closed_clients, session tuningsquid-config-blocklist.test.tssquid-config-ssl-bump.test.tssquid-config-dlp.test.tsNo source code changes. Each file reproduces the shared import boilerplate (
generateSquidConfig,SquidConfig) independently. All 56 tests pass.