Skip to content

Get Correlation ID through GoFr's context #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

coolwednesday
Copy link
Member

@coolwednesday coolwednesday commented Aug 13, 2025

Pull Request Template

Description:

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@coolwednesday coolwednesday changed the title Get Correlation ID through GoFr'd context Get Correlation ID through GoFr's context Aug 13, 2025
Comment on lines +259 to +265
if len(correlationID) != 32 {
t.Errorf("Expected correlation ID length 32, got %d", len(correlationID))
}

if correlationID == "00000000000000000000000000000000" {
t.Error("Expected non-empty correlation ID")
}
Copy link
Contributor

@akshat-kumar-singhal akshat-kumar-singhal Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use assert.NotEqual, assert.Len

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow accessing co-relation id from context as well as returning it in errors
2 participants