Skip admin and change oidc user not found message more readable #21061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21061 +/- ##
==========================================
+ Coverage 45.36% 46.19% +0.82%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6413 +364
- Misses 6983 7132 +149
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
from
4ba168e to
06d5924
Compare
5 tasks
|
+1, this would be very helpful |
|
+1 |
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
2 times, most recently
from
93cfdc4 to
c6ce7bc
Compare
stonezdj
added
target/2.13.0
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
from
c6ce7bc to
58b9680
Compare
|
+1 |
Vad1mo
previously requested changes
Dec 18, 2024
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
from
58b9680 to
f4c472e
Compare
wy65701436
reviewed
Jan 2, 2025
wy65701436
reviewed
Jan 2, 2025
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
from
5e3fe1b to
ba05fa0
Compare
fixes goharbor#21041 Signed-off-by: stonezdj <[email protected]>
stonezdj
force-pushed
the
24oct18_oidc_admin_error
branch
from
ba05fa0 to
20def46
Compare
ianseyer
pushed a commit
to ianseyer/harbor
that referenced
this pull request
Feb 3, 2025
…rbor#21061) fixes goharbor#21041 Signed-off-by: stonezdj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21041
verified in local env
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: