Skip to content

Add configure item for audit_log_disable #21368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

stonezdj
Copy link
Contributor

Add configure item audit_log_disable

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner December 31, 2024 05:43
@stonezdj stonezdj added release-note/update Update or Fix release-note/new-feature New Harbor Feature and removed release-note/update Update or Fix labels Dec 31, 2024
@stonezdj stonezdj requested review from wy65701436 and reasonerjt and removed request for a team December 31, 2024 05:43
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.20%. Comparing base (c8c11b4) to head (2e5b0ae).
Report is 347 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21368      +/-   ##
==========================================
+ Coverage   45.36%   46.20%   +0.83%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6415     +366     
- Misses       6983     7129     +146     
- Partials      301      339      +38     
Flag Coverage Δ
unittests 46.20% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj stonezdj requested a review from chlins January 2, 2025 02:55
@stonezdj stonezdj force-pushed the 24dec31_add_configure_audit branch from 89a3e02 to 5869494 Compare January 3, 2025 02:57
@stonezdj stonezdj requested a review from MinerYang January 3, 2025 05:44
@stonezdj stonezdj enabled auto-merge (squash) January 3, 2025 05:52
@stonezdj stonezdj force-pushed the 24dec31_add_configure_audit branch 3 times, most recently from 08aa248 to 6777013 Compare January 3, 2025 06:44
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

   Add configure item audit_log_disable

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 24dec31_add_configure_audit branch from 6777013 to 2e5b0ae Compare January 6, 2025 07:45
@stonezdj stonezdj merged commit 875f43b into goharbor:main Jan 6, 2025
12 checks passed
ianseyer pushed a commit to ianseyer/harbor that referenced this pull request Feb 3, 2025
Add configure item audit_log_disable

Signed-off-by: stonezdj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants