Skip to content

support to audit logs #21377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

support to audit logs #21377

merged 1 commit into from
Feb 21, 2025

Conversation

xuelichao
Copy link
Contributor

Support to display new format of audit logs

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • [*] Well Written Title and Summary of the PR
  • [*] Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • [*] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [*] Made sure tests are passing and test coverage is added if needed.
  • [*] Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao requested a review from a team as a code owner January 6, 2025 04:00
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.24%. Comparing base (c8c11b4) to head (e5f715a).
Report is 382 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21377      +/-   ##
==========================================
+ Coverage   45.36%   46.24%   +0.87%     
==========================================
  Files         244      249       +5     
  Lines       13333    14044     +711     
  Branches     2719     2898     +179     
==========================================
+ Hits         6049     6494     +445     
- Misses       6983     7206     +223     
- Partials      301      344      +43     
Flag Coverage Δ
unittests 46.24% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 493 files with indirect coverage changes

@xuelichao xuelichao added target/2.13.0 issues that are targeting v2.13.0 release-note/enhancement Label to mark PR to be added under release notes as enhancement labels Jan 6, 2025
@xuelichao xuelichao requested a review from stonezdj January 12, 2025 01:29
@xuelichao xuelichao force-pushed the audit-log-ui branch 5 times, most recently from e5f715a to ec784ee Compare February 13, 2025 09:03
Signed-off-by: Lichao Xue <[email protected]>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit b837bbb into goharbor:main Feb 21, 2025
10 checks passed
@OrlinVasilev
Copy link
Member

@xuelichao can you please edit the PR message to add some more information about the new format as we need this information for the release notes, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants