Skip to content

Implement audit log ext API #21414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 14, 2025 09:58
@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label Jan 14, 2025
@stonezdj stonezdj requested review from wy65701436 and chlins January 14, 2025 09:59
@stonezdj stonezdj enabled auto-merge (squash) January 14, 2025 09:59
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.20%. Comparing base (c8c11b4) to head (2278d44).
Report is 366 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21414      +/-   ##
==========================================
+ Coverage   45.36%   46.20%   +0.83%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6414     +365     
- Misses       6983     7131     +148     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.20% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/breaking-change Breaking changes in the release label Jan 15, 2025
@stonezdj stonezdj force-pushed the 25jan10_add_auditlogext_api branch from 8db04ec to 42c599c Compare January 16, 2025 05:31
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 added the release-note/docs Docs changes(made and needed) label Jan 16, 2025
@stonezdj stonezdj force-pushed the 25jan10_add_auditlogext_api branch from 42c599c to a7a099b Compare January 16, 2025 05:33
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 25jan10_add_auditlogext_api branch 2 times, most recently from abb62e5 to 11709c5 Compare January 16, 2025 08:46
@stonezdj stonezdj force-pushed the 25jan10_add_auditlogext_api branch from 11709c5 to 2278d44 Compare January 16, 2025 08:47
@stonezdj stonezdj merged commit 4d5bc19 into goharbor:main Jan 16, 2025
12 checks passed
ianseyer pushed a commit to ianseyer/harbor that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/breaking-change Breaking changes in the release release-note/docs Docs changes(made and needed) release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants