-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add user event and config event #21455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21455 +/- ##
==========================================
+ Coverage 45.36% 46.26% +0.89%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6423 +374
- Misses 6983 7121 +138
- Partials 301 339 +38
Flags with carried forward coverage won't be shown. Click here to find out more. |
4551baf
to
031defe
Compare
031defe
to
400fa1f
Compare
400fa1f
to
0b1fe4b
Compare
099ccbf
to
a23cee6
Compare
bae85a4
to
e64784b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
deddf96
to
b03aa19
Compare
Signed-off-by: stonezdj <[email protected]>
b03aa19
to
352ac6d
Compare
SucceedCodes []int | ||
// SensitiveAttributes is the attributes that need to be redacted | ||
SensitiveAttributes []string | ||
// HasResourceName indicates if the resource has name, if true, need to resolve the resource name before delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revise the comments as well.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: