Skip to content

add redis tls support for core&jobservice #21654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#21629

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0 labels Feb 20, 2025
@MinerYang MinerYang requested a review from a team as a code owner February 20, 2025 11:54
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.38%. Comparing base (c8c11b4) to head (1169d2e).
Report is 452 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21654      +/-   ##
==========================================
+ Coverage   45.36%   46.38%   +1.01%     
==========================================
  Files         244      249       +5     
  Lines       13333    14047     +714     
  Branches     2719     2897     +178     
==========================================
+ Hits         6049     6515     +466     
- Misses       6983     7189     +206     
- Partials      301      343      +42     
Flag Coverage Δ
unittests 46.38% <ø> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 493 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
Copy link
Member

chlins commented Feb 24, 2025

If Redis uses a self-signed certificate, does the user need to mount the certificate in advance?

@MinerYang
Copy link
Contributor Author

MinerYang commented Feb 24, 2025

If Redis uses a self-signed certificate, does the user need to mount the certificate in advance?

User only needs to specify the rootca path in values.yaml, and prepare would take care of the mount path defined in dokcer-compose.yaml, then utilize the install_cert.sh to inject the certificate to system trusted directory.
This would be handled in a separate PR
general process please refer to https://github.com/goharbor/community/blob/main/proposals/new/Redis-TLS-support.md#config-via-offline-installer

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang enabled auto-merge (squash) February 25, 2025 06:33
@MinerYang MinerYang merged commit 9e84d03 into goharbor:main Feb 25, 2025
12 checks passed
@MinerYang MinerYang added release-note/new-feature New Harbor Feature and removed release-note/update Update or Fix labels Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants