-
Notifications
You must be signed in to change notification settings - Fork 4.9k
add redis tls support for core&jobservice #21654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b734dbb
to
8f76bba
Compare
8f76bba
to
7826e8b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21654 +/- ##
==========================================
+ Coverage 45.36% 46.38% +1.01%
==========================================
Files 244 249 +5
Lines 13333 14047 +714
Branches 2719 2897 +178
==========================================
+ Hits 6049 6515 +466
- Misses 6983 7189 +206
- Partials 301 343 +42
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
If Redis uses a self-signed certificate, does the user need to mount the certificate in advance? |
User only needs to specify the rootca path in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: yminer <[email protected]>
7826e8b
to
1169d2e
Compare
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
#21629
Please indicate you've done the following: