Skip to content

[cherry-pick]revise make file for lint api #21932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wy65701436
Copy link
Contributor

Decouple the lint from the api generation step in the makefile.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Decouple the lint from the api generation step in the makefile.

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 requested a review from a team as a code owner April 25, 2025 09:00
@wy65701436 wy65701436 added the release-note/update Update or Fix label Apr 25, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.13.0@40e78d5). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.13.0   #21932   +/-   ##
=================================================
  Coverage                  ?   46.55%           
=================================================
  Files                     ?      253           
  Lines                     ?    14233           
  Branches                  ?     2924           
=================================================
  Hits                      ?     6626           
  Misses                    ?     7256           
  Partials                  ?      351           
Flag Coverage Δ
unittests 46.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wy65701436 wy65701436 merged commit a37118f into goharbor:release-2.13.0 Apr 25, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants