Close TCP endpoints on restore error instead of panics. #12025
Merged
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl794286565
branch
2 times, most recently
from
9e127a8 to
af0eb7a
Compare
Restoring of TCP endpoints can fail due to various reasons, some of them are: - when the port used by the endpoint during checkpoint is already being used by some host socket during restore. - when the new route cannot be found due to changes in the network config. During these failures instead of panic'ing and aborting the restore, log a warning and close the failing connection. PiperOrigin-RevId: 795118834
copybara-service
bot
force-pushed
the
test/cl794286565
branch
from
af0eb7a to
25a1144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close TCP endpoints on restore error instead of panics.
Restoring of TCP endpoints can fail due to various reasons, some of them are:
by some host socket during restore.
During these failures instead of panic'ing and aborting the restore, log a
warning and close the failing connection.