Add XPRESS support to the MathOpt Python API#5271
Open
jaxor24 wants to merge 1 commit into
Open
Conversation
The proto and C++ layers already support the Xpress MathOpt backend (SOLVER_TYPE_XPRESS, XpressParametersProto, and the SolveParametersProto xpress field), but the Python layer did not expose it. - Add SolverType.XPRESS. - Add the XpressParameters wrapper (name/value controls) and wire it into SolveParameters.to_proto(). - Add the StreamableXpressInitArguments placeholder for solver-instantiation parity with the other solvers. - Re-export XpressParameters and StreamableXpressInitArguments from mathopt. - Extend parameters_test.py coverage and add the xpress_py_pb2 build dep.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exposes the existing Xpress MathOpt backend through the MathOpt Python API.
The proto and C++ layers already support Xpress
(
SOLVER_TYPE_XPRESS,XpressParametersProto,XpressParametersincpp/parameters.{h,cc}, and theSolveParametersProto.xpressfield), and thenative backend ships in the wheel. Only the Python layer was missing the
corresponding surface, so
mathopt.solve(model, SolverType.XPRESS)was notusable from Python.
Changes
parameters.pySolverType.XPRESS(maps toSOLVER_TYPE_XPRESS).XpressParameterswrapper (name/value controls), mirroringGurobiParametersand the C++XpressParametersstruct.SolveParameters.xpressfield and serialize it into_proto().init_arguments.pyStreamableXpressInitArgumentsplaceholder and the correspondingStreamableSolverInitArguments.xpressfield, for parity with the othersolvers.
mathopt.pyXpressParametersandStreamableXpressInitArguments(required bythe
mathopt_test.pypublic-API check).parameters_test.pyXpressParameters.to_prototest and anxpresscase intest_to_proto_with_specifics;test_solver_type_round_tripnow covers thenew enum member automatically.
BUILD.bazel//ortools/math_opt/solvers:xpress_py_pb2to theparameterslibraryand
parameters_test(thepy_prototarget already existed).Testing
Validated against the published OR-Tools 9.15 wheel with Xpress 9.9:
parameters_test.py— 17/17 pass (includes the new Xpress coverage).init_arguments_test.py— 5/5 pass.SolverType.XPRESSandXpressParameters(param_values={"PRESOLVE": "0"})returned
TerminationReason.OPTIMALwith the expected solution; the nativeXpress backend loaded and applied the solver-specific control.
No changes to the C++/proto layers.