datastore: force import grpc-google-common-protos:0.1.9 - #2029
Merged
Conversation
Also removes grpc-all dependency from top-level pom.xml; it is unused. Datastore is tested with `mvn verify`. Depedency versions are shown to not conflict by creating and compiling a test project that depends only on google-cloud. Since it does not inherit the version resolution from google-cloud-java/pom.xml, it more closely resembles user project.
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 1985918 on pongad:datastore-versioning into ** on GoogleCloudPlatform:master**. |
vam-google
reviewed
May 3, 2017
vam-google
left a comment
vam-google
left a comment
Contributor
There was a problem hiding this comment.
Please ensure that this works as expected:
rm -r ~/.m2/repository
mvn clean install -DskipITs (from google-cloud-java repo root)
| <dependency> | ||
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>grpc-google-common-protos</artifactId> | ||
| <version>0.1.9</version> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@vam-google PTAL |
|
Changes Unknown when pulling 6a6dc8a on pongad:datastore-versioning into ** on GoogleCloudPlatform:master**. |
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>grpc-google-common-protos</artifactId> | ||
| <version>${generatedProto.version}</version> | ||
| </dependency> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Merging with @vam-google 's +2. @garrettjonesgoogle I'll follow up in email. |
This was referenced May 4, 2017
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
🤖 I have created a release *beep* *boop* --- ## [2.34.1](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.34.0...v2.34.1) (2023-03-21) ### Bug Fixes * Add service_yaml_parameters to `java_gapic_library` targets ([#2034](https://togithub.com/googleapis/java-bigquerystorage/issues/2034)) ([8dae87c](https://togithub.com/googleapis/java-bigquerystorage/commit/8dae87cff06c7d08b9d597be9c66de570739abf4)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.23.2 ([#2029](https://togithub.com/googleapis/java-bigquerystorage/issues/2029)) ([e9c0152](https://togithub.com/googleapis/java-bigquerystorage/commit/e9c0152c2b098d7fb2d1de4d535d636a3ac9f90e)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.5.0 ([#2050](https://togithub.com/googleapis/java-bigquerystorage/issues/2050)) ([349092f](https://togithub.com/googleapis/java-bigquerystorage/commit/349092f28f6017b1df5b325e9a9036c311e70546)) * Update dependency com.google.http-client:google-http-client to v1.43.1 ([#2038](https://togithub.com/googleapis/java-bigquerystorage/issues/2038)) ([5e865c9](https://togithub.com/googleapis/java-bigquerystorage/commit/5e865c9b3779f0d20080eead241f1b5858156880)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
🤖 I have created a release *beep* *boop* --- ## [1.129.5](https://togithub.com/googleapis/java-pubsub/compare/v1.129.4...v1.129.5) (2024-05-16) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.38.1 ([#2027](https://togithub.com/googleapis/java-pubsub/issues/2027)) ([535edf6](https://togithub.com/googleapis/java-pubsub/commit/535edf6496700bc5c5fb0b5cfa1cac6be5d62875)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.30.1 ([#2028](https://togithub.com/googleapis/java-pubsub/issues/2028)) ([aedcffd](https://togithub.com/googleapis/java-pubsub/commit/aedcffdaedbaa30627c96f96bfa5430bd4666cf0)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
🤖 I have created a release *beep* *boop* --- ## [1.129.5](https://togithub.com/googleapis/java-pubsub/compare/v1.129.4...v1.129.5) (2024-05-16) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.38.1 ([#2027](https://togithub.com/googleapis/java-pubsub/issues/2027)) ([f7127b5](https://togithub.com/googleapis/java-pubsub/commit/f7127b57320dff05c096f4ca0bc4ecb0516b6eff)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.30.1 ([#2028](https://togithub.com/googleapis/java-pubsub/issues/2028)) ([e0a2cc3](https://togithub.com/googleapis/java-pubsub/commit/e0a2cc344dcd1440be3eaff4c4ceb09076c1b145)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin
pushed a commit
that referenced
this pull request
May 2, 2026
…plugin to v3.1.4 (#2029) Co-authored-by: Tom Andersen <tom-andersen@users.noreply.github.com>
benjaminp
pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…duces correct results (googleapis#2029) Change-Id: I909ec95bebe87219d66b387cd80e7095e75252a2 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes grpc-all dependency from top-level pom.xml; it is unused.
Datastore is tested with
mvn verify.Depedency versions are shown to not conflict by
creating and compiling a test project that depends
only on google-cloud.
Since it does not inherit the version resolution
from google-cloud-java/pom.xml,
it more closely resembles user project.