Skip to content

pubsub: eventually stop polling after termination #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pongad merged 2 commits into from
Jun 6, 2017
Merged

pubsub: eventually stop polling after termination #2113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
007c0ef
pubsub: eventually stop polling after termination
pongad Jun 5, 2017
dbcb1ef
pr comment
pongad Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...loud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ protected void doStop() {
}

private void pullMessages(final Duration backoff) {
if (!isAlive()) {

This comment was marked as spam.

Sign in to view

return;
}
ListenableFuture<PullResponse> pullResult =
stub.withDeadlineAfter(DEFAULT_TIMEOUT.toMillis(), TimeUnit.MILLISECONDS)
.pull(
Expand Down Expand Up @@ -201,7 +204,9 @@ public void run() {
}

private boolean isAlive() {
return state() == State.RUNNING || state() == State.STARTING;
// Read state only once. Because of threading, different calls can give different results.
State state = state();
return state == State.RUNNING || state == State.STARTING;
}

@Override
Expand Down