Refactor crypto_test.go to use Web Platform Tests #4979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace static hardcoded tests with official WPT tests - Add getRandomValues.any.js and randomUUID.https.any.js to test suite - Create WebCryptoAPI__getRandomValues.any.js.patch for Float16Array compatibility - Remove crypto_test.go with 268 lines of static test code - Improve maintainability by using standards-compliant WPT tests - Ensure automatic updates as web standards evolve Closes grafana#4268
paulnegz
requested review from
inancgumus and
ankur22
and removed request for
a team
|
|
…cPushInterval from 1ms to 10ms to ensure flusher gets called\n- Increase test timeout from 1s to 5s to avoid flaky tests\n- Update both TestOutputFlushWorkersStop and TestOutputFlushWorkersAbort
inancgumus
approved these changes
Aug 5, 2025
inancgumus
requested changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aligns
crypto_test.gowith the Web Platform Tests (WPT) approach, following the successful pattern established insubtle_crypto_test.go. Specifically:Removed Static Tests:
crypto_test.goAdded WPT Integration:
getRandomValues.any.jsfor testing random value generationrandomUUID.https.any.jsfor UUID functionality testingRuntime Compatibility:
WebCryptoAPI__getRandomValues.any.js.patchfor Float16Array handlingWhy?
This refactoring addresses issue 4268:
Maintainability:
Standards Compliance:
Future-Proofing:
Implementation Details
The implementation follows the same successful approach used in grafana/xk6-webcrypto#90, ensuring consistency across the WebCrypto API testing suite.
All tests are passing, and the changes maintain full backward compatibility while improving test coverage and maintainability.
Closes 4268