experimental/websockets: support code and reason for close() and close event

[etodanik]

What?

Closes #4972

With a small caveat: I wasn't sure the proper implementation for wasClean and prefer to contribute it as a second later PR, after I get to read the RFC spec about it a bit more in depth.

Checklist

• I have performed a self-review of my code.
• I have commented on my code, particularly in hard-to-understand areas.
• I have added tests for my changes.
• I have run linter and tests locally (make check) and all pass.

[CLAassistant]

All committers have signed the CLA.

[etodanik]

@mstoykov @inancgumus just clarifying if there's anything else I can help with, or is this good on track for release?
I see tests are failing, but they're rather flaky to begin with. They actually pass, but that whole test suite has leaks that are there regardless of this PR.

[mstoykov]

Hi @etodanik, thank you for the PR.

We are in the last week before releasing v1.2.0 - planned for next week. As such we are unlikely to be able to review this, within the week.

Looking at the CI - you probably should try to fix the lint issues. Also test are failing with races within the experimental websockets, while they weren't before. So you probably have introduced a race condition. Running test with -race locally might help you find the root cause and confirm that you have fixed.

I would argue both will need to be fixed before this is mergeable.

[etodanik]

Hi @etodanik, thank you for the PR.

We are in the last week before releasing v1.2.0 - planned for next week. As such we are unlikely to be able to review this, within the week.

Looking at the CI - you probably should try to fix the lint issues. Also test are failing with races within the experimental websockets, while they weren't before. So you probably have introduced a race condition. Running test with -race locally might help you find the root cause and confirm that you have fixed.

I would argue both will need to be fixed before this is mergeable.

Ok. I'll attend to the linter stuff as well as the tests. However, I should note that even if I remove my tests and code completely , that whole test suite is flaky & fails half the time for me

[etodanik]

@mstoykov could we re-run CI/CD tasks? I fixed linter's complaints about long line & test flakiness.

[etodanik]

Appreciate it. Hmm , I'll look at what the GH Action actually runs and make sure to get the same fails locally. Looks like I'm not catching the data race errors.

[etodanik]

Alright, data race should be fixed now :)

[etodanik]

@mstoykov ready for another go at CI/CD :)