Skip to content

fix: bump federation composition to address subgraph type leakage#7402

Merged
n1ru4l merged 1 commit into
mainfrom
fix-leaked-subgraph-federation-directives
Dec 10, 2025
Merged

fix: bump federation composition to address subgraph type leakage#7402
n1ru4l merged 1 commit into
mainfrom
fix-leaked-subgraph-federation-directives

Conversation

@n1ru4l

@n1ru4l n1ru4l commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Background

https://linear.app/the-guild/issue/CONSOLE-1643

Description

Prevent subgraph-specific federation types and scalars being re-declared within the subgraph leaking into the supergraph.

See graphql-hive/federation-composition#230 for more details.

Checklist

  • Input validation
  • Output encoding
  • Authentication management
  • Session management
  • Access control
  • Cryptographic practices
  • Error handling and logging
  • Data protection
  • Communication security
  • System configuration
  • Database security
  • File management
  • Memory management
  • Testing

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve an issue where subgraph-specific types and scalars were inadvertently leaking into the supergraph during the federation schema composition process. By bumping the @theguild/federation-composition dependency to its latest patch version, the change ensures a cleaner and more accurate federated schema, preventing unintended type declarations from affecting the overall supergraph definition.

Highlights

  • Dependency Update: The @theguild/federation-composition package has been updated from version 0.21.0 to 0.21.1 across multiple package.json files within the repository.
  • Schema Composition Improvement: This update specifically addresses and prevents subgraph-specific federation types and scalars from being re-declared and leaking into the supergraph during native federation schema composition.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@n1ru4l n1ru4l changed the title bump federation composition to address subgraph type leakage fix: bump federation composition to address subgraph type leakage Dec 10, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @theguild/federation-composition dependency to version 0.21.1 across all relevant packages in the monorepo. This is done to address an issue with subgraph type leakage during native federation composition. A changeset file has been correctly added to document this patch-level change. The dependency bump is applied consistently, and the changes look good.

@github-actions

Copy link
Copy Markdown
Contributor

📚 Storybook Deployment

The latest changes are available as preview in: https://pr-7402.hive-storybook.pages.dev

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 8.13.0-alpha-20251210130031-971110f5db710509ea6c592d604ef02f05246833 npm ↗︎ unpkg ↗︎

@github-actions

Copy link
Copy Markdown
Contributor

💻 Website Preview

The latest changes are available as preview in: https://pr-7402.hive-landing-page.pages.dev

@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 971110f5db710509ea6c592d604ef02f05246833

@n1ru4l n1ru4l merged commit 4183e55 into main Dec 10, 2025
27 checks passed
@n1ru4l n1ru4l deleted the fix-leaked-subgraph-federation-directives branch December 10, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants