fix: bump federation composition to address subgraph type leakage#7402
Conversation
Summary of ChangesHello @n1ru4l, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to resolve an issue where subgraph-specific types and scalars were inadvertently leaking into the supergraph during the federation schema composition process. By bumping the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the @theguild/federation-composition dependency to version 0.21.1 across all relevant packages in the monorepo. This is done to address an issue with subgraph type leakage during native federation composition. A changeset file has been correctly added to document this patch-level change. The dependency bump is applied consistently, and the changes look good.
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7402.hive-storybook.pages.dev |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7402.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
Background
https://linear.app/the-guild/issue/CONSOLE-1643
Description
Prevent subgraph-specific federation types and scalars being re-declared within the subgraph leaking into the supergraph.
See graphql-hive/federation-composition#230 for more details.
Checklist