Add missing message for no details on schema check/push changes#7675
Conversation
Summary of ChangesHello @jdolle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user experience gap by reintroducing and enhancing messages displayed when specific details for schema check or push changes are unavailable in the UI. It ensures that users receive clear feedback, indicating 'No details available' for changes that lack specific descriptions, improving clarity and preventing empty UI states. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a fallback message for schema changes that don't have detailed usage information, which was previously missing. The change is straightforward. I've suggested an improvement to ensure that the severityReason is always displayed when available, regardless of the change's severity level, which the current implementation doesn't do for non-breaking changes.
| ) : change.severityLevel === SeverityLevelType.Breaking ? ( | ||
| <>{change.severityReason ?? 'No details available for this breaking change.'}</> | ||
| ) : ( | ||
| <>No details available for this change.</> | ||
| )} |
There was a problem hiding this comment.
This implementation hides severityReason for non-breaking changes (e.g., DANGEROUS). Additionally, the logic for the fallback messages can be made more concise. The suggested change ensures severityReason is always shown if available, and simplifies the fallback message generation.
) : (
<>
{change.severityReason ??
`No details available for this ${
change.severityLevel === SeverityLevelType.Breaking ? 'breaking ' : ''
}change.`}
</>
)}
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7675.hive-landing-page.pages.dev |
3 participants
Background
This was accidentally deleted previously
Description
Adds message to changes which otherwise lack usage details