Skip to content

feat: enable app deployments#7769

Merged
n1ru4l merged 4 commits into
mainfrom
feat-enable-app-deployments
Mar 4, 2026
Merged

feat: enable app deployments#7769
n1ru4l merged 4 commits into
mainfrom
feat-enable-app-deployments

Conversation

@n1ru4l

@n1ru4l n1ru4l commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

it is stable and been running in production for an extensive amount of time 👍

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request promotes two key features, persisted documents and app deployments, from experimental/preview status to stable. The experimental__persistedDocuments configuration option has been officially renamed to persistedDocuments across all relevant packages, simplifying its usage. Concurrently, app deployments are now enabled by default for all organizations, removing the need for explicit opt-in and streamlining their adoption. These changes reflect a significant step in maturing these features within the GraphQL Hive ecosystem.

Highlights

  • Persisted Documents Stabilization: The experimental__persistedDocuments configuration option has been officially renamed to persistedDocuments across the @graphql-hive/apollo, @graphql-hive/core, and @graphql-hive/yoga packages, signifying its transition from experimental to stable.
  • App Deployments Enabled by Default: App deployments are now stable and enabled by default for all organizations, removing the previous "preview" status and streamlining their adoption.
  • Documentation and Configuration Updates: All relevant documentation and environment variable configurations have been updated to reflect the stabilization of both persisted documents and app deployments, including removal of "experimental" prefixes and "preview" callouts.
Changelog
  • .changeset/breezy-wolves-beam.md
    • Persisted documents feature is now stable, use persistedDocuments instead of experimental__persistedDocuments.
  • .changeset/slow-otters-tell.md
    • App deployments are now stable and enabled for all organizations by default.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.48.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.58.4-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.21.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.5-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.48.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 npm ↗︎ unpkg ↗︎
hive 9.6.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 npm ↗︎ unpkg ↗︎

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of graduating the persisted documents feature to stable by renaming experimental__persistedDocuments to persistedDocuments. However, the refactoring appears to be incomplete. Some related properties still use the experimental__ prefix, which could lead to API inconsistency and confusion.

Specifically:

  • In packages/libraries/core/src/client/types.ts, the experimental__persistedDocumentHash parameter in collectRequest, collectSubscriptionUsage, and CollectUsageCallback should be renamed to persistedDocumentHash.
  • In packages/libraries/yoga/src/index.ts, the CacheRecord type still has an experimental__documentId property that should be renamed.

Addressing these would complete the refactoring and make the API more consistent. I've also added a minor suggestion for fixing a typo in the changeset.

Comment thread packages/libraries/yoga/src/index.ts Outdated
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 452bd03b1ee1ec6b760f232c0d90c1f90811dc66

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

💻 Website Preview

The latest changes are available as preview in: https://pr-7769.hive-landing-page.pages.dev

@n1ru4l n1ru4l marked this pull request as ready for review March 4, 2026 14:18
@n1ru4l n1ru4l merged commit ee2785c into main Mar 4, 2026
26 checks passed
@n1ru4l n1ru4l deleted the feat-enable-app-deployments branch March 4, 2026 14:18
This was referenced Mar 4, 2026
n1ru4l added a commit that referenced this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant