feat: enable app deployments#7769
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request promotes two key features, persisted documents and app deployments, from experimental/preview status to stable. The Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.48.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.58.4-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.21.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.40.5-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.48.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 |
npm ↗︎ unpkg ↗︎ |
hive |
9.6.0-alpha-20260304133336-452bd03b1ee1ec6b760f232c0d90c1f90811dc66 |
npm ↗︎ unpkg ↗︎ |
There was a problem hiding this comment.
Code Review
This pull request does a great job of graduating the persisted documents feature to stable by renaming experimental__persistedDocuments to persistedDocuments. However, the refactoring appears to be incomplete. Some related properties still use the experimental__ prefix, which could lead to API inconsistency and confusion.
Specifically:
- In
packages/libraries/core/src/client/types.ts, theexperimental__persistedDocumentHashparameter incollectRequest,collectSubscriptionUsage, andCollectUsageCallbackshould be renamed topersistedDocumentHash. - In
packages/libraries/yoga/src/index.ts, theCacheRecordtype still has anexperimental__documentIdproperty that should be renamed.
Addressing these would complete the refactoring and make the API more consistent. I've also added a minor suggestion for fixing a typo in the changeset.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7769.hive-landing-page.pages.dev |
it is stable and been running in production for an extensive amount of time 👍