Skip to content

fix: bump @theguild/federation-composition to 0.22.0#7778

Merged
n1ru4l merged 1 commit into
mainfrom
fix-bump-federation-composition-0.22.0
Mar 5, 2026
Merged

fix: bump @theguild/federation-composition to 0.22.0#7778
n1ru4l merged 1 commit into
mainfrom
fix-bump-federation-composition-0.22.0

Conversation

@n1ru4l

@n1ru4l n1ru4l commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the @theguild/federation-composition library to version 0.22.0 across the project. This update incorporates critical improvements to federation composition rules, specifically addressing issues with @join__field generation in scenarios involving @override and @requires directives. It also introduces a new validation to prevent progressive overrides from conflicting with @requires directives on source fields, enhancing the robustness and correctness of supergraph composition.

Highlights

  • Dependency Update: The @theguild/federation-composition package has been updated from version 0.21.3 to 0.22.0 across various package.json files in the repository.
  • Federation Composition Fixes: Improved the generation of supergraph @join__field directives, specifically addressing scenarios involving @override and @requires migrations.
  • External Annotation Logic: Enhanced the composition logic to prevent stale external annotations by ignoring @requires usage from the overridden source field when determining whether to keep @join__field(..., external: true).
  • Progressive Override Restriction: Introduced a new restriction that rejects progressive overrides (@override(..., label: ...)) when the overridden source field utilizes @requires, issuing an OVERRIDE_COLLISION_WITH_ANOTHER_DIRECTIVE error.
Changelog
  • .changeset/weak-pugs-stay.md
    • Improved federation composition rules.
    • Fixed supergraph @join__field generation for @override + @requires migrations and added a progressive override restriction.
    • Modified composition logic to ignore @requires usage from overridden source fields when determining @join__field(..., external: true), preventing stale external annotations.
    • Implemented a rejection for progressive overrides (@override(..., label: ...)) when the overridden source field uses @requires, issuing an OVERRIDE_COLLISION_WITH_ANOTHER_DIRECTIVE error.
  • integration-tests/package.json
    • Updated @theguild/federation-composition from 0.21.3 to 0.22.0.
  • package.json
    • Updated @theguild/federation-composition from 0.21.3 to 0.22.0.
  • packages/libraries/cli/package.json
    • Updated @theguild/federation-composition from 0.21.3 to 0.22.0.
  • packages/services/api/package.json
    • Updated @theguild/federation-composition from 0.21.3 to 0.22.0.
  • packages/services/demo/federation/package.json
    • Updated @theguild/federation-composition from 0.21.3 to 0.22.0.
  • packages/services/schema/package.json
    • Updated @theguild/federation-composition from 0.21.3 to 0.22.0.
  • packages/services/server/package.json
    • Updated @theguild/federation-composition from 0.21.3 to 0.22.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.48.0-alpha-20260305113833-9d235550043ccdfe0bfc53ea9a69cf56a6d0c91c npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.58.4-alpha-20260305113833-9d235550043ccdfe0bfc53ea9a69cf56a6d0c91c npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.21.0-alpha-20260305113833-9d235550043ccdfe0bfc53ea9a69cf56a6d0c91c npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.5-alpha-20260305113833-9d235550043ccdfe0bfc53ea9a69cf56a6d0c91c npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.48.0-alpha-20260305113833-9d235550043ccdfe0bfc53ea9a69cf56a6d0c91c npm ↗︎ unpkg ↗︎
hive 9.6.0-alpha-20260305113833-9d235550043ccdfe0bfc53ea9a69cf56a6d0c91c npm ↗︎ unpkg ↗︎

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @theguild/federation-composition dependency to version 0.22.0 across multiple packages in the repository. A corresponding changeset file has been added to document the improvements in federation composition rules included in this new version. The changes are consistent and follow the repository's release process. I find no issues with this update.

Note: Security Review has been skipped due to the limited scope of the PR.

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 9d235550043ccdfe0bfc53ea9a69cf56a6d0c91c

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

💻 Website Preview

The latest changes are available as preview in: https://pr-7778.hive-landing-page.pages.dev

@n1ru4l n1ru4l merged commit 3c05b96 into main Mar 5, 2026
24 of 26 checks passed
@n1ru4l n1ru4l deleted the fix-bump-federation-composition-0.22.0 branch March 5, 2026 11:59
jdolle added a commit that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant