Run clickhouse app deployment checks in parallel to speed up schema c…

[jdolle]

…heck resolution

Background

https://linear.app/the-guild/issue/CONSOLE-1949/network-error-during-graphql-hive-cli-schema-check

Some checks are timing out for orgs with a large number of app deployments and a large number of breaking changes.

Description

This runs three of the clickhouse queries for app deployments in parallel. Although this means overall we'll be making more queries to clickhouse, it will speed up the resolution of schema.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the performance of schema check resolution by parallelizing key ClickHouse queries. Previously, these queries were executed sequentially, leading to timeouts for larger organizations. By refactoring the main method to call these queries concurrently using Promise.all, the overall execution time is reduced, enhancing the reliability and speed of schema checks without altering the core logic or results.

Highlights

• Performance Improvement: Implemented parallel execution for three ClickHouse queries related to app deployments to speed up schema check resolution.
• Code Refactoring: Refactored the getAffectedAppDeploymentsBySchemaCoordinates method by extracting its sub-queries into three new private methods for better modularity and readability.
• Schema Check Efficiency: Addressed timeouts experienced by organizations with a large number of app deployments and breaking changes by optimizing query execution.

Changelog

• packages/services/api/src/modules/app-deployments/providers/app-deployments.ts
  • Refactored getAffectedAppDeploymentsBySchemaCoordinates to orchestrate parallel calls to new private methods.
  • Introduced getActiveDeployments private method to fetch active deployments.
  • Introduced getTotalEffectedDeployments private method to count total affected deployments.
  • Introduced getPaginatedAffectedDeployments private method to retrieve paginated affected deployment IDs.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: edfa7676abb973d1b4cf528d6cef42e8bb344730

[gemini-code-assist]

Code Review

This pull request refactors the getAffectedAppDeploymentsBySchemaCoordinates method to run three ClickHouse queries in parallel, which should improve performance as intended. The logic has been broken down into smaller, private methods. My review includes a minor suggestion to correct a typo in a new method name for better maintainability, and a suggestion for a further performance optimization by parallelizing another query.

[github-actions]

💻 Website Preview

The latest changes are available as preview in: https://pr-7828.hive-landing-page.pages.dev

[github-actions]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
hive	9.7.1-alpha-20260311194303-edfa7676abb973d1b4cf528d6cef42e8bb344730	npm ↗︎ unpkg ↗︎