Skip to content

feat: bump clickhouse-server docker image#8120

Merged
n1ru4l merged 9 commits into
mainfrom
feat-upgrade-clickhouse-server
Jun 10, 2026
Merged

feat: bump clickhouse-server docker image#8120
n1ru4l merged 9 commits into
mainfrom
feat-upgrade-clickhouse-server

Conversation

@n1ru4l

@n1ru4l n1ru4l commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Background

Bump clickhouse/clickhouse-server:24.8-alpine to clickhouse/clickhouse-server:26.3.12.3-alpine.

The main breaking change is the quoting of integers, this is handled gracefully by using the output_format_json_quote_64bit_integers option for clickhouse client queries.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 5, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ClickHouse server image version to 26.3.12.3-alpine in the Docker Compose files. However, ClickHouse version 26.x does not exist, making this tag invalid. Please correct this to a valid version (e.g., 24.3.12.3-alpine). Additionally, since files under /docker are modified, a changeset for the hive scope is required.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker/docker-compose.community.yml
Comment thread docker/docker-compose.dev.yml
@github-actions

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: f4b0bbb1962308a70320153a0618535e20ef5c57

@github-actions

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/apollo 0.48.1-alpha-20260610074215-f4b0bbb1962308a70320153a0618535e20ef5c57 npm ↗︎ unpkg ↗︎
@graphql-hive/cli 0.60.1-alpha-20260610074215-f4b0bbb1962308a70320153a0618535e20ef5c57 npm ↗︎ unpkg ↗︎
@graphql-hive/core 0.21.1-alpha-20260610074215-f4b0bbb1962308a70320153a0618535e20ef5c57 npm ↗︎ unpkg ↗︎
@graphql-hive/envelop 0.40.6-alpha-20260610074215-f4b0bbb1962308a70320153a0618535e20ef5c57 npm ↗︎ unpkg ↗︎
@graphql-hive/yoga 0.48.1-alpha-20260610074215-f4b0bbb1962308a70320153a0618535e20ef5c57 npm ↗︎ unpkg ↗︎
hive 11.3.0-alpha-20260610074215-f4b0bbb1962308a70320153a0618535e20ef5c57 npm ↗︎ unpkg ↗︎

@n1ru4l n1ru4l force-pushed the feat-upgrade-clickhouse-server branch from ff861fb to 807b1fb Compare June 5, 2026 11:37
n1ru4l
n1ru4l commented Jun 9, 2026
View reviewed changes
Comment thread packages/migrations/src/clickhouse-actions/001-initial.ts
Comment on lines -185 to +189
const action: Action = exec => Promise.all(statements.map(q => exec(q))).then(() => {});
const action: Action = async exec => {
for (const query of statements) {
await exec(query);
}
};

@n1ru4l n1ru4l Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n1ru4l n1ru4l force-pushed the feat-upgrade-clickhouse-server branch from 807b1fb to f03e2e1 Compare June 9, 2026 08:35
@n1ru4l n1ru4l marked this pull request as ready for review June 9, 2026 10:42
@n1ru4l n1ru4l changed the title feat: bump clickhouse-server feat: bump clickhouse-server docker image Jun 9, 2026
@n1ru4l n1ru4l marked this pull request as draft June 9, 2026 11:59
@n1ru4l n1ru4l marked this pull request as ready for review June 10, 2026 11:43
@n1ru4l n1ru4l merged commit 065e087 into main Jun 10, 2026
68 of 70 checks passed
@n1ru4l n1ru4l deleted the feat-upgrade-clickhouse-server branch June 10, 2026 11:43
@theguild-bot theguild-bot mentioned this pull request Jun 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdolle jdolle Awaiting requested review from jdolle
@dotansimha dotansimha Awaiting requested review from dotansimha
@kamilkisiela kamilkisiela Awaiting requested review from kamilkisiela
1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@n1ru4l