Skip to content

Add configuration for selecting specific dangerous change types to fail on#8175

Open
jdolle wants to merge 10 commits into
mainfrom
failing-dangerous-changes-config
Open

Add configuration for selecting specific dangerous change types to fail on#8175
jdolle wants to merge 10 commits into
mainfrom
failing-dangerous-changes-config

Conversation

@jdolle

@jdolle jdolle commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Background

Dangerous changes can be situational based on a team's accepted risk and deployment process.

Description

This introduces a new configuration option which allows selecting individual change types.

fail-dangerous-preview.mp4

@jdolle jdolle self-assigned this Jun 25, 2026
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 11.4.0-alpha-20260625231545-e5a3473505651303bca3305a9f5b0f911f7e1cb7 npm ↗︎ unpkg ↗︎

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces granular configuration for failing dangerous change types on targets, adding database columns, GraphQL schema updates, and a frontend form to select specific dangerous changes. The review feedback focuses on simplifying a complex SQL update query, adding proper error handling with toast notifications on the frontend form submission to prevent misleading success states, improving type safety in Zod and Yup schemas, resolving conflicting CSS classes on disabled buttons, and using environment-agnostic types for timers.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/services/storage/src/index.ts
Comment thread packages/web/app/src/pages/target-settings.tsx Outdated
Comment thread packages/web/app/src/pages/target-settings.tsx Outdated
Comment thread packages/services/storage/src/index.ts Outdated
Comment thread packages/web/app/src/components/ui/button.tsx
Comment thread packages/web/app/src/pages/target-settings.tsx Outdated
Comment thread packages/web/app/src/pages/target-settings.tsx Outdated
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tags: e5a3473505651303bca3305a9f5b0f911f7e1cb7, e5a3473

@jdolle jdolle marked this pull request as ready for review June 25, 2026 22:10
jdolle and others added 5 commits June 25, 2026 15:22
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant