Update terms with latest resources #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default Gilda terms file with the latest version of resources such as UniProt, HGNC, MeSH, GO, etc. The FamPlex benchmark got better due to the recognition of a new EFO term, and the BioID evaluation also generally got better. There are a couple of regressions that I tracked down: nuclear chromatin and cytoplasmic chromatin are curated in the benchmark to obsolete GO terms which were replaced by a term (https://amigo.geneontology.org/amigo/term/GO:0000785) for which these are narrow synonyms and therefore there is no longer a correct GO term to ground these to.