Fix nested template panic #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for this @mihaitodor!! I'm surprised there wasn't an integration test that caught this - I'll add one of those too. I'll be glad to get rid of the old (list of strings) syntax, since supporting both formats is a huge pain 😅 |
mihaitodor
force-pushed
the
fix-nested-template-panic
branch
from
134a061 to
81ce441
Compare
|
I've found a simpler way to fix this, right in the |
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
approved these changes
Aug 18, 2022
|
Nice find @hairyhenderson! I was sure there is a better way to fix this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive attempt to fix a panic that came up on the #gomplate channel on the Gophers Slack. I'm really not sure if this is the best way to fix the issue, but the changes in
TestParseConfigFilewill help you reproduce the issue easily. Alternatively, maybe this customUnmarshalYAMLshould take the receiver by value rather than by pointer, but I'm not sure if the rest of the custom logic will still work in that case.