-
Notifications
You must be signed in to change notification settings - Fork 56
Support device awareness of result_type and promote_types #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support device awareness of result_type and promote_types #1836
Conversation
…Apple-silicon-GPUs
…Apple-silicon-GPUs
…:helmholtz-analytics/heat into features/1053-support-Apple-silicon-GPUs
…ort-Apple-silicon-GPUs
…nd change the types accordingly
…sult_type_promote_types
…/1820-Support_device_awareness_of_result_type_promote_types
…sult_type_promote_types
…sult_type_promote_types
…sult_type_promote_types
…sult_type_promote_types
Thank you for the PR! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
==========================================
- Coverage 92.10% 88.95% -3.16%
==========================================
Files 86 86
Lines 13144 13159 +15
==========================================
- Hits 12106 11705 -401
- Misses 1038 1454 +416
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…sult_type_promote_types
Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a couple of instances where references to MPS need to be removed from the codebase. Some quick examples that I found:
_operations.py: _binary_op and _cum_op
arithmetics.py: hypot and hypot_
There might be more, but those are some I could find quickly that already use promote_type
or result_type
. The references to MPS should be removable.
Otherwise, great code. Thanks!
Due Diligence
Description
Apple MPS don't support double precision floats or complex numbers, so this PR introduces some checks for that in result_type and promote_types.
Issue/s resolved: #1820
Changes proposed:
Type of change
Bug fix (non-breaking change which fixes an issue)
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
no