Skip to content

fix(spinner): fix variant spinner animation #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yurkimus
Copy link

@yurkimus yurkimus commented Aug 5, 2025

Closes

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Style
    • Updated the "fade-out" animation to introduce a staggered delay, creating a cascading effect based on each element’s index.

@yurkimus yurkimus requested a review from jrgarciadev as a code owner August 5, 2025 23:45
Copy link

changeset-bot bot commented Aug 5, 2025

⚠️ No Changeset found

Latest commit: df74a0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 5, 2025

@yurkimus is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Aug 5, 2025

Walkthrough

The "fade-out" animation in the animation definitions was updated to use a dynamic delay based on the CSS variable --bar-index, replacing the previous fixed delay. No other animation parameters or exported/public entities were changed.

Changes

Cohort / File(s) Change Summary
Fade-out Animation Delay Update
packages/core/theme/src/animations/index.ts
Modified "fade-out" animation to use calc(var(--bar-index) * 100ms) for animation delay instead of 0s.

Sequence Diagram(s)

sequenceDiagram
    participant CSS
    participant DOM_Element

    CSS->>DOM_Element: Apply "fade-out" animation with delay calc(var(--bar-index) * 100ms)
    Note right of DOM_Element: Animation starts staggered based on --bar-index value
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Add --bar-index variable to "fade-out" animation delay (#5577)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/core/theme/src/animations/index.ts (1)

9-9: Fix looks correct; consider trimming redundant tokens for consistency.

The updated shorthand now correctly injects the dynamic delay, resolving #5577.
However, unlike the other animation strings in this object (e.g. "spinner-spin 0.8s ease infinite"), this one explicitly lists the default direction, fill-mode, and play-state (normal none running). They are super­fluous because those values are the browser defaults; keeping them inflates bundle size and introduces style‐guide inconsistency.

-"fade-out": "fade-out 1.2s linear calc(var(--bar-index) * 100ms) infinite normal none running",
+"fade-out": "fade-out 1.2s linear calc(var(--bar-index) * 100ms) infinite",

Optional, but worth aligning with the rest of the file.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8b1c85 and df74a0a.

📒 Files selected for processing (1)
  • packages/core/theme/src/animations/index.ts (1 hunks)

@yurkimus yurkimus changed the title Fix Spinner variant spinner animation fix(spinner): fix variant spinner animation Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant