Skip to content

Add with_split to DatasetDict.map #7368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 7, 2025
Merged

Add with_split to DatasetDict.map #7368

merged 17 commits into from
Mar 7, 2025

Conversation

jp1924
Copy link
Contributor

@jp1924 jp1924 commented Jan 13, 2025

@jp1924
Copy link
Contributor Author

jp1924 commented Jan 13, 2025

Can you check this out, @lhoestq?

@jp1924
Copy link
Contributor Author

jp1924 commented Jan 20, 2025

cc @lhoestq @albertvillanova

@jp1924
Copy link
Contributor Author

jp1924 commented Feb 4, 2025

@lhoestq

@jp1924
Copy link
Contributor Author

jp1924 commented Feb 12, 2025

@lhoestq

1 similar comment
@jp1924
Copy link
Contributor Author

jp1924 commented Feb 13, 2025

@lhoestq

@jp1924 jp1924 mentioned this pull request Feb 19, 2025
Closed
lhoestq
lhoestq reviewed Feb 19, 2025
View reviewed changes
@jp1924 jp1924 requested a review from lhoestq February 21, 2025 07:50
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

lhoestq
lhoestq reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! just added minor comments but LGTM

before we merge can you also ad the same for IterableDatasetDict ?

@jp1924 jp1924 requested a review from lhoestq February 24, 2025 12:48
@jp1924
Copy link
Contributor Author

jp1924 commented Mar 3, 2025

@lhoestq

@jp1924
Copy link
Contributor Author

jp1924 commented Mar 6, 2025

@lhoestq please...

lhoestq
lhoestq approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! and sorry for the delay !

@lhoestq lhoestq merged commit f693f4e into huggingface:main Mar 7, 2025
14 checks passed
@jp1924
Copy link
Contributor Author

jp1924 commented Mar 8, 2025

Thank you so much for reviewing this PR! Have a great weekend~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jp1924 @HuggingFaceDocBuilderDev @lhoestq