[SYCL][DOC] Updates to sycl_ext_oneapi_reusable_events specification.#22201
Merged
KornevNikita merged 5 commits intoJun 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the proposed sycl_ext_oneapi_reusable_events extension specification to reflect that counter-based events may be enqueued for signaling on any device in the system, removing the previously documented requirement for P2P accessibility between the event’s device and the queue’s device.
Changes:
- Removed the documented
_Throws_condition that required P2P access (and referencedext_oneapi_can_access_peer/ext_oneapi_enable_peer_access) whenevtandqwere associated with different devices. - Keeps the
enqueue_signal_eventbehavior consistent with the rest of the document’s cross-device/cross-context event usage remarks.
gmlueck
reviewed
Jun 3, 2026
Counter based events can be enqueued for signaling on any device in the system, so there is no requirement for P2P access between devices.
slawekptak
changed the title
slawekptak
changed the title
functions, minor changes.
gmlueck
reviewed
Jun 18, 2026
This reverts commit a5fec19.
gmlueck
reviewed
Jun 22, 2026
gmlueck
approved these changes
Jun 23, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please consider merging |
wenju-he
pushed a commit
that referenced
this pull request
Jun 26, 2026
…#22201) List of changes: - Counter based events can be enqueued for signaling on any device in the system, so there is no requirement for P2P access between devices. - The `device` argument is not required for make_event, since the event is associated with a device on the first call to enqueue_signal_event. Which device is associated with an event (if any) right after the make_event call is implementation specific. - A new device aspect for reusable events (since this extension might not be supported on all backends).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes:
deviceargument is not required for make_event, since the event is associated with a device on the first call to enqueue_signal_event. Which device is associated with an event (if any) right after the make_event call is implementation specific.