Skip to content

#2379 Remove OSVR from JME VR #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025

Conversation

richardTingle
Copy link
Member

OSVR is very outdated and is unlikely to still have users

Discussed at https://hub.jmonkeyengine.org/t/should-osvr-very-old-vr-standard-be-removed-from-jme/48234

@richardTingle
Copy link
Member Author

I tested this by exercising OpenVR (LWJGL version) on a Quest 3 just to make sure I hadn't inadvertently broken OpenVR support when I deleted OSVR. I also included the changes from #2371 when testing so tested on the most recent LWJGL

@yaRnMcDonuts yaRnMcDonuts added this to the v3.8.0 milestone Feb 24, 2025
# Conflicts:
#	jme3-vr/src/main/java/com/jme3/input/vr/osvr/OSVR.java
@richardTingle
Copy link
Member Author

@yaRnMcDonuts I've resolved the merge conflict this previously had

@yaRnMcDonuts
Copy link
Member

I will merge in the next 24-48 hours.

Thanks for all your efforts maintaining VR for JME!

I unfortunately don't have the equipment for VR dev and testing yet myself, but I look forward to getting into it eventually in the future.

@richardTingle
Copy link
Member Author

I look forward to getting into it eventually in the future.

I think VR has suddenly come of age. It has gone from disappointingly poor to actually quite good. Still not many major publishers there yet though (which makes it a good time for the Indie developer)

@yaRnMcDonuts yaRnMcDonuts merged commit 0059fca into jMonkeyEngine:master Mar 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants