SSAOFilter: javadoc + fix approximateNormals serialization #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaRnMcDonuts
approved these changes
Jun 12, 2025
capdevon
changed the title
capdevon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the
SSAOFilterby:SSAOFilterclass and all public methods. This improves clarity, explains parameters, return values, and provides better context for filter usage.approximateNormals: TheapproximateNormalsboolean parameter was not being correctly saved or loaded during asset serialization and deserialization. This PR resolves the issue by explicitly includingapproximateNormalsin thewrite()andread()methods, ensuring its state is persisted.These changes enhance the maintainability and reliability of the
SSAOFilter.