Skip to content

third_party: Add libunwind #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

trungnt2910
Copy link
Collaborator

Added libunwind from LLVM 17.0.6.
The library includes functions required for C++ exception handling.

Requires the latest cosmo GCC with commit ahgamut/superconfigure@c1e5a6e for SJLJ exceptions (should have the __USING_SJLJ_EXCEPTIONS__ macro defined by default).

Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you need me to add it to cosmocc?

@jart
Copy link
Owner

jart commented Jan 4, 2024

@trungnt2910 Could you fix the test failures?

@trungnt2910
Copy link
Collaborator Author

trungnt2910 commented Jan 5, 2024

I can reproduce the build failures using the default cosmocc package, but not using the version mentioned above.

Seems like an update to the blobs at third_party/gcc. Can you please update those to the latest ones released in the superconfigure repo?

jart added a commit that referenced this pull request Jan 5, 2024
The toolchain will now be downloaded going forward from multiple pinned
URLs which have shasums. Either wget or curl must be installed.

This change unblocks #1053
Added libunwind from LLVM 17.0.6.
The library includes functions required for C++ exception handling.
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/libunwind branch from aff654b to e63ecb9 Compare January 5, 2024 16:09
@trungnt2910 trungnt2910 merged commit b090966 into jart:master Jan 6, 2024
@jart jart mentioned this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants