apeinstall.sh cleanup #1057
Merged
apeinstall.sh cleanup #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `build/bootstrap/make.com` if it's available, in case the system make is BSD make. - Handle aarch64, rather than installing the x86_64 loader everywhere. - Detect whether the elf or macho loader is wanted and fetch only that. - Print an error and exit on unsupported architectures. - Consistently prepend x to uname tests.
Cleans up the temporary Apple Silicon loader with a trap, which also gets it if the mkdir fails.
|
Tested on M1 Mac, aarch64 and x86_64 Linux. |
Also updates ape loaders so that this will do something reasonable. XXX broken on kernels older than 5.12. We should test for this.
jart
approved these changes
Jan 5, 2024
JoshuaWierenga
added a commit
to JoshuaWierenga/cosmopolitan
that referenced
this pull request
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
build/bootstrap/make.comif it's available, in case the system make is BSD make.Handle aarch64, rather than installing the x86_64 loader everywhere (fixes apeinstall.sh installs x86_64 loader on aarch64 linux #1050).
Detect whether the elf or macho loader is wanted and fetch only that.
Print an error and exit on unsupported architectures.
Consistently prepend x to uname tests.
Use
installif available. (Cleans up the temporary M1 loader with a trap.)