Skip to content

Unwinding fixes #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Unwinding fixes #1069

merged 2 commits into from
Jan 8, 2024

Conversation

trungnt2910
Copy link
Collaborator

@trungnt2910 trungnt2910 commented Jan 7, 2024

Further unwinding fixes.

These changes allow the first exception handling binaries to build and run successfully on cosmo.

Part of #1065.

@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/libunwind branch 2 times, most recently from d4049e2 to 64e06e9 Compare January 7, 2024 12:03
These intefere with the real unwind implementation in `libunwind`.

`libunwind` has been added to `cosmopolitan.a` to replace the stubs.
`resumeParameters` in `_Unwind_FunctionContext` should be "unwind words"
(typically 64-bit) instead of 32-bit.

This fix, along with the pending libcxxabi port, allows the first
binaries with exception handling to properly run.
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jart jart merged commit 94bab16 into jart:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants