tool/cosmocc: Properly handle dependency output #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2753de contains some regressions, causing `fixupobj` to be inappropriately suppressed when `-MD` or `-MMD` is passed. This commit reverts most changes by a2753de, and: - Treats all invocations of the compiler with `-M` and `-MM` as with the `cpp` intent, since these flags imply `-E`. - Handle the dependency output path specified by `-MF`. + This is trivial for `cosmocross` since the script does not throw objects to and from temporary directories. + For `cosmocc`, the file names are calculated based on the `-MF` value provided by the user. If this flag is not specified, the script generates the file name based on the output file using GCC rules. Then, before calling the real compilers, an additional `-MF` flag is passed to override the dependency outputs with mangled file names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a2753de contains some regressions, causing
fixupobjto be inappropriately suppressed when-MDor-MMDis passed.This commit reverts most changes by a2753de, and:
-Mand-MMas with thecppintent, since these flags imply-E.-MF.cosmocrosssince the script does not throw objects to and from temporary directories.cosmocc, the file names are calculated based on the-MFvalue provided by the user. If this flag is not specified, the script generates the file name based on the output file using GCC rules. Then, before calling the real compilers, an additional-MFflag is passed to override the dependency outputs with mangled file names.