Remove .com logic from GetProgramExecutableName #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `com` parameter to `TryPath` was always 1, so there was no reason to have it. This patch changes the logic to be as though `com` was 0, which provides a possible answer to the TODO question -- the answer is no. If we never care about appending `.com`, then `CopyWithCwd` doesn't need to return anything beyond a boolean success value.
G4Vi
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't imagine any way that appending
".com"would still be relevant fromGetProgramExecutableName’s perspective. However, my lack of imagination may be mere ignorance; in that case, I’d suggest still removing thecomparameter and having the code always take thecom == 1path.