Fix fork locking on win32 #1141
Conversation
|
Drafting this as it's incomplete, on win32 without pthreads it leaves the child unable to open files. |
|
Fixed the win32 non-pthread child not initializing the locks. Also decided to with |
|
Why are threads required for win32 process management? |
|
I'm not really sure other than it's critical to the win32 fork implementation and is used to wait on child processes. |
|
The conflict came from clang-format line-breaking the short if statement; should be trivial to resolve. |
- __enable_threads / set __threaded in __proc_setup as threads are required for win32 subprocess management - move mmi/fds locking out of pthread_atfork.c into fork.c so it's done anytime __threaded is set instead of being dependent of pthreads - explicitly yoink _pthread_onfork_prepare, _pthread_onfork_parent, and _pthread_onfork_child in pthread_create.c so they are linked in in-case they are separated from _pthread_atfork Big Thanks to @dfyz for help with locating the issue, testing, and devising a fix!
…ssary locks on fork
G4Vi
force-pushed
the
fix-win32-fork-locking
branch
from
0b236a9 to
4b39d15
Compare
Fixes #1138
__enable_threads/ set__threadedin__proc_setupas threads are required for win32 subprocess management__threadedis set instead of being dependent of pthreads_pthread_onfork_prepare,_pthread_onfork_parent, and_pthread_onfork_childin pthread_create.c so they are linked in in-case they are separated from_pthread_atforkBig Thanks to @dfyz for help with locating the issue, testing, and devising a fix!