remove zlib namespacing #1142
Merged
remove zlib namespacing #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahgamut
force-pushed
the
zlib-namespacing
branch
from
5aeb0fa to
faf77cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems like we can handle the zlib dependency fine both inside and outside the monorepo without having to do any sort of namespacing.
I remember we added the namespacing for the zlib functions because it was clashing with some builds (but I don't remember the exact reason 😞 ). Do we still have those clashing builds now? The namespaced symbols are now causing an issue with ahgamut/superconfigure#29