Skip to content

Change loop bound on uuidv4 test #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Change loop bound on uuidv4 test #1143

merged 1 commit into from
Apr 12, 2024

Conversation

mrdomino
Copy link
Collaborator

A half second (on my machine) is too long for a unit test. 1000 iterations is probably still overkill, but 0.01 seconds is fine.

Also made y local.

A half second (on my machine) is too long for a unit test. 1000
iterations is probably still overkill, but 0.01 seconds is fine.

Also made `y` local.
@mrdomino
Copy link
Collaborator Author

cc @solisoft

Copy link
Collaborator

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@G4Vi G4Vi merged commit 06839ab into jart:master Apr 12, 2024
@solisoft
Copy link
Contributor

Oh nice

@mrdomino mrdomino deleted the uuidv4-test branch April 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants