Update MODE=tiny time zone list #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took one canonical IANA zone ID from each of the different colored regions in this article, except those that do not observe DST and do not at present contain a Google office: <https://en.wikipedia.org/wiki/Time_in_Europe> As to which canonical ID to use, this was somewhat arbitrary. Brussels was obvious, as the de facto capital of the EU. For the rest, I mostly just went with lexicographic ordering of the most recognizable options.
Keeps the U.S. ones together but does everything alphabetically otherwise.
These have DST (and Newfoundland is off by a half-hour from a UTC interval) so they cannot use Etc/.
This is the last of the zones that I'm aware of that has a non-integer hour offset from UTC.
jart
requested changes
May 6, 2024
|
Done although I now wonder if we should include e.g. Budapest so that we get "Central Europe Standard Time", which, Brussels is mapped to "Romance Standard Time" (which is the same time zone) for some reason. |
|
Also do you want the newly added ones added to that list? |
|
I looked at it a bit more and I can't make heads or tails of the list of Windows timezone names. I'm fine with merging this as-is, the supported list does not include anything that is not available anymore. |
jart
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winnows down Europe to one zone per different set of current offsets / DST rules in each region that contains a Google office (so excepting Iceland, Kaliningrad, and Armenia / Georgia / Samara, which all do not observe DST and as such can use a
Etc/zone without issue.)Adds some outliers, in particular:
Total net space in
o/tiny/examples/localtimeis about -5kb.